Re: [code-review] Just subscribed

Simon Cozens <simon-eH/[email protected]> Thu, 18 Sep 2003 11:52:16 +0100
Newsgroups gmane.comp.lang.perl.code-review-ladder
Message-ID <[email protected]>
Jean-Michel Hiver:
> I just saw the article in use Perl; and I am very enthusiastic about
> this list.

Welcome!

> Recently I uploaded MKDoc::XML [1] on CPAN, 

Obligatory name flame: none of this needs to be in a private namespace, since
that implies it's not useful outside of the MKDoc context. (and hence shouldn't
be on CPAN) If there's just a generic XML tokenizer, it should be called
XML::Tokenizer. 

It might be nicer for XML::Tokenizer to use qr// for the compiled regexes.
In MKDoc::XML::Token, you're doing yourself a disservice by writing comments
on the methods then documenting them in the POD later. Documenting something
twice is almost as bad as writing code twice.

-- 
I respect faith, but doubt is what gives you an education.
		-- Wilson Mizner