Re: [code-review] Just subscribed

On Thu, Sep 18, 2003 at 11:41:22AM +0100, Jean-Michel Hiver wrote:
> Indeed in exchange I would be very happy to give constructive remarks on
> any code you might want to throw at me :)

I'll remark on docs first rather than code:

I find this sort of thing to be quite confusing:

  use MKDoc::XML::Decode;

  # $xml is now "Chris' Baloon"
  my $xml = MKDoc::XML::Decode->process ("Chris' Baloon"); 


I read from top to bottom, and expect the comments to make sense in that
order. So the middle line confused me quite a bit, until I realised that
by 'now' you meant 'after the next line is executed' rather than 'before
the next line is executed'.


Next I'mm enquire as to why MKDoc::XML::DecodeHO "is heavily stolen from
HTML::Entities". If all it's doing is providing a standardised
interface, can't it just use HTML::Entities internally, rather than
copy'n'pasting all the entities from that? No need for both of you to
maintain this...


Then I'll ask why you don't rename MKDoc::XML::Dumper into something like
Data::Dumper::XML, and release it on its own...

Tony