Re: [code-review] Just subscribed

> >Recently I uploaded MKDoc::XML [1] on CPAN, MKDoc's unique XML
> >manipulation toolkit which provides not so common XML features. I would
> >like to submit this module for review.
> 
> The code is ok overall by my criteria, but since it isn't an XML parser I 
> think you should change the name. An XML parser would have died the first 
> time there:

That's what happens when you use one big rexeg :)

As for the XML tokenizer, I am not sure. As far as I am aware - correct
me if I'm wrong - the XML specification states that XML *PARSERS* should
die on not well formed XML.

I would think it's a matter of layering, really... MKDoc::XML::Tokenizer
could be used as a tool to build a proper XML parser given the right
amount of checking. But it's not an XML parser, which is why it's called
a tokenizer :)

IMHO the fact that MKDoc::XML::* suite of tools does tolerate some
amount of invalid XML does not necessarily make it unrelated to XML.
For example if I were to make a module that actually fixes invalid XML,
wouldn't it make sense to call it something like XML::Fixer, XML::Neat
or XML::Tidy?

Cheers,
-- 
Building a better web - http://www.mkdoc.com/
---------------------------------------------
Jean-Michel Hiver
[email protected]  - +44 (0)114 255 8097
Homepage: http://www.webmatrix.net/