Re: Style-Patch for DBD::DBM

On Fri, 30 Apr 2010 06:20:02 +0000, Jens Rehsack
<[email protected]> wrote:

> On 04/29/10 17:32, Tim Bunce wrote:
> > On Wed, Apr 28, 2010 at 12:49:21PM +0000, Jens Rehsack wrote:
> >> Hi Tim,
> >>
> >> here is the style patch I spoke about in IRC (channel #dbi on
> >> irc.perl.org for everyone who still misses IRC). It should help me
> >> applying future patches sent in via RT for the new DBI version. I
> >> think, I need to invest more time into the module now ...
> >
> >> -sub driver ($;$) {
> >> +sub driver ($;$)
> >> +{
> >
> >> -    if ( $DBI::VERSION>= 1.37 and !$methods_already_installed++ ) {
> >> +    if ( $DBI::VERSION>= 1.37 and !$methods_already_installed++ )
> >> +    {
> >
> > Thanks Jens.
> >
> > For the record, I dislike this style of brace placement for perl code.

Neither do I, but I know how important style is.

> > If you're going to be the principle maintainer of DBD::DBM
> 
> That was the plan. I think, I'll add the perltidy rules in the comment at 
> file head, so everyone can edit in own favorite style and format back for 
> creating patch.

Done for mine, with README in
r13938 = 7583b08ebefae59be496843d53cb3b2606a518d6 (refs/remotes/git-svn)

Tim, If you have a perltidyrc for the basic style, please add

> > then I've no
> > objection to the style being used in that file and related tests.
> 
> Thanks :)
> 
> > If you need to make changes elsewhere, though, please use the existing
> > brace placement style.
> 
> As always (e.g. see my patches to DBD::File). I have some reasons for my 
> style, as Merijn has reasons for his one and you surely have reasons for 
> your style.
> 
> DBI++
> 
> Best regards,
> Jens


-- 
H.Merijn Brand  http://tux.nl      Perl Monger  http://amsterdam.pm.org/
using 5.00307 through 5.12 and porting perl5.13.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3.
http://mirrors.develooper.com/hpux/           http://www.test-smoke.org/
http://qa.perl.org      http://www.goldmark.org/jeff/stupid-disclaimers/