Re: Style-Patch for DBD::DBM

On Fri, Apr 30, 2010 at 08:53:19AM +0200, H.Merijn Brand wrote:
> On Fri, 30 Apr 2010 06:20:02 +0000, Jens Rehsack
> <[email protected]> wrote:
> 
> > On 04/29/10 17:32, Tim Bunce wrote:
> > > On Wed, Apr 28, 2010 at 12:49:21PM +0000, Jens Rehsack wrote:
> > >> Hi Tim,
> > >>
> > >> here is the style patch I spoke about in IRC (channel #dbi on
> > >> irc.perl.org for everyone who still misses IRC). It should help me
> > >> applying future patches sent in via RT for the new DBI version. I
> > >> think, I need to invest more time into the module now ...
> > >
> > >> -sub driver ($;$) {
> > >> +sub driver ($;$)
> > >> +{
> > >
> > >> -    if ( $DBI::VERSION>= 1.37 and !$methods_already_installed++ ) {
> > >> +    if ( $DBI::VERSION>= 1.37 and !$methods_already_installed++ )
> > >> +    {
> > >
> > > Thanks Jens.
> > >
> > > For the record, I dislike this style of brace placement for perl code.
> 
> Neither do I, but I know how important style is.
> 
> > > If you're going to be the principle maintainer of DBD::DBM
> > 
> > That was the plan. I think, I'll add the perltidy rules in the comment at 
> > file head, so everyone can edit in own favorite style and format back for 
> > creating patch.
> 
> Done for mine, with README in
> r13938 = 7583b08ebefae59be496843d53cb3b2606a518d6 (refs/remotes/git-svn)
> 
> Tim, If you have a perltidyrc for the basic style, please add

I rarely use perltidy but the perltidyrc file I use when needed is from
the Perl Best Practices book (with some official errata) with just these
overrides:

--nohanging-side-comments               # troublesome for commented out code
--maximum-line-length=100               # be slightly more generous
    (because readability shouldn't be sacrificed for a relic of a bygone age)
--maximum-consecutive-blank-lines=2     # default is 1
    (because I like two blank lines between subs)

But let's not get into a debate on styles :)

I've added mine to devel/

Tim.