[PATCH] URL and stutter fixes

Blair Zajac <[email protected]> Thu, 06 May 2004 15:06:56 -0700

Newsgroups	gmane.comp.lang.perl.modules.mail-box
Message-ID	<[email protected]>

Hi Mark,

There's a typo in this line in Makefile.PL

named libdbx (website http://sorceforge.net/project/ol2mbox/),

The URL should be

http://sourceforge.net/projects/ol2mbox

The missing 'u' gets fake site that wants to change your browser's
home page.  Not nice.  Note also the missing 's' in project.

Also, here's a patch that removes stutters.  BTW, here's the
code that finds stutters:

#!/usr/bin/perl
undef $/;
$* = 1;
while ( $ARGV = shift ) {
    if (!open ARGV) { warn "$0: cannot open `$ARGV' for reading: $!\n"; next; }
    $_ = <ARGV>;
    s/\b(\s?)(([A-Za-z]\w*)(\s+\3)+\b)/$1\200$2\200/g || next;
    split(/\n/);
    $NR = 0;
    @hits = ();
    for (@_) {
        $NR++;
        push(@hits, sprintf("%5d %s", $NR, $_)) if /\200/;
    }
    $_ = join("\n",@hits);
    s/\200([^\200]+)\200/[* $1 *]/g;
    print "stutter: $ARGV:\n$_\n" if length $_;
}

Best,
Blair

-- 
Blair Zajac <[email protected]>
Plots of your system's performance - http://www.orcaware.com/orca/

mail-box-stutter-patch.txt (text/plain, 7.8 KB)

diff -ru ../Mail-Box-2.054-orig/ChangeLog ./ChangeLog
--- ../Mail-Box-2.054-orig/ChangeLog	2004-02-06 12:43:26.000000000 -0800
+++ ./ChangeLog	2004-05-06 14:55:23.000000000 -0700
@@ -665,7 +665,7 @@
           for large messages.  This was due to IO::ScalarArray (being
           extremely slow in seeks), which now is replaced by IO::Scalar.
 
-        - Do not use eval{binmode $fh}, but carefully check whether the
+        - Do not use eval{binmode $fh}, but carefully check whether
           the $fh can handle binmode before calling it in the parser.
 
         - Remove newlines from header field data which is passed as
@@ -2106,7 +2106,7 @@
 
         - Removed a back-reference from a locker object to the folder,
           by which the folders where kept alive although out of scope.
-          "circular reference".  According the the errors I got when
+          "circular reference".  According the errors I got when
           removing this one, there should be no strong refs left.
 
         - replaced many "warn"s by "$self->log(WARNING =>"s in
diff -ru ../Mail-Box-2.054-orig/lib/Mail/Box/Search/SpamAssassin.pod ./lib/Mail/Box/Search/SpamAssassin.pod
--- ../Mail-Box-2.054-orig/lib/Mail/Box/Search/SpamAssassin.pod	2004-02-06 12:47:18.000000000 -0800
+++ ./lib/Mail/Box/Search/SpamAssassin.pod	2004-05-06 14:51:28.000000000 -0700
@@ -100,7 +100,7 @@
 
 =over 4
 
-Mark all selected selected message with the specified STRING.  If this
+Mark all selected message with the specified STRING.  If this
 option is explicitly set to C<undef>, the label will not be set.
 
 =back
diff -ru ../Mail-Box-2.054-orig/lib/Mail/Box/Search.pod ./lib/Mail/Box/Search.pod
--- ../Mail-Box-2.054-orig/lib/Mail/Box/Search.pod	2004-02-06 12:47:18.000000000 -0800
+++ ./lib/Mail/Box/Search.pod	2004-05-06 14:51:55.000000000 -0700
@@ -176,7 +176,7 @@
 added to the set of already selected messages.
 
 C<NOT> is true for messages which do not fulfil the search.  The
-details output will still contain the places where the the match was
+details output will still contain the places where the match was
 found, however those messages will complementary set of messages will
 be labeled and returned.
 
@@ -443,5 +443,3 @@
 Copyright (c) 2001-2003 by the author(s). All rights reserved.
 This program is free software; you can redistribute it and/or modify it
 under the same terms as Perl itself.
-
-
diff -ru ../Mail-Box-2.054-orig/lib/Mail/Box/Thread/Manager.pod ./lib/Mail/Box/Thread/Manager.pod
--- ../Mail-Box-2.054-orig/lib/Mail/Box/Thread/Manager.pod	2004-02-06 12:47:18.000000000 -0800
+++ ./lib/Mail/Box/Thread/Manager.pod	2004-05-06 14:51:38.000000000 -0700
@@ -265,7 +265,7 @@
 
 Usually, all messages which are in reply of this message are dated later
 than the specified one.  All headers of messages later than this one are
-are getting parsed first, for each folder in this threads-object.
+getting parsed first, for each folder in this threads-object.
 
 I<Example:> 
 
diff -ru ../Mail-Box-2.054-orig/lib/Mail/Box/Tie/ARRAY.pod ./lib/Mail/Box/Tie/ARRAY.pod
--- ../Mail-Box-2.054-orig/lib/Mail/Box/Tie/ARRAY.pod	2004-02-06 12:47:18.000000000 -0800
+++ ./lib/Mail/Box/Tie/ARRAY.pod	2004-05-06 14:51:10.000000000 -0700
@@ -131,7 +131,7 @@
 
 =over 4
 
-Random message replacement is is not permitted--doing so would disturb threads
+Random message replacement is not permitted--doing so would disturb threads
 etc.  An error occurs if you try to do this. The only thing which is allowed
 is to store a message at the first free index at the end of the folder (which
 is also achievable with L<PUSH()|Mail::Box::Tie::ARRAY/"Tied Interface">).
diff -ru ../Mail-Box-2.054-orig/lib/Mail/Message/Convert/Html.pod ./lib/Mail/Message/Convert/Html.pod
--- ../Mail-Box-2.054-orig/lib/Mail/Message/Convert/Html.pod	2004-02-06 12:47:19.000000000 -0800
+++ ./lib/Mail/Message/Convert/Html.pod	2004-05-06 14:52:49.000000000 -0700
@@ -80,7 +80,7 @@
 =over 4
 
 Format one field from the header to HTML.  When the header line usually
-usually contains e-mail addresses, the line is scanned and valid addresses
+contains e-mail addresses, the line is scanned and valid addresses
 are linked with an C<mailto:> anchor.  The SUBJECT can be specified to
 be included in that link.
 
diff -ru ../Mail-Box-2.054-orig/lib/Mail/Message/Field.pod ./lib/Mail/Message/Field.pod
--- ../Mail-Box-2.054-orig/lib/Mail/Message/Field.pod	2004-02-06 12:47:19.000000000 -0800
+++ ./lib/Mail/Message/Field.pod	2004-05-06 14:53:03.000000000 -0700
@@ -827,7 +827,7 @@
 string.  If the same fieldname appears more than once in the header,
 only the last value is returned.
 
-When L<Mail::Message::Head::get()|Mail::Message::Head/"Access to the header"> is called in scalar context, the
+When L<Mail::Message::Head::get()|Mail::Message::Head/"Access to the header"> is called in scalar context,
 the last field with the specified name is returned as field B<object>.
 This object strinigfies into the unfolded contents of the field, including
 attributes and comments.  In list context, all appearances of the field
diff -ru ../Mail-Box-2.054-orig/lib/Mail/Message/Head/ResentGroup.pod ./lib/Mail/Message/Head/ResentGroup.pod
--- ../Mail-Box-2.054-orig/lib/Mail/Message/Head/ResentGroup.pod	2004-02-06 12:47:19.000000000 -0800
+++ ./lib/Mail/Message/Head/ResentGroup.pod	2004-05-06 14:52:36.000000000 -0700
@@ -56,7 +56,7 @@
 compatibility reasons, without arguments L<resentFrom()|Mail::Message::Head::ResentGroup/"Access to the header"> is called to
 return the C<From> field of this resent group.
 
-With any arguments, a a list of C<Mail::Message::Head::ResentGroup> objects
+With any arguments, a list of C<Mail::Message::Head::ResentGroup> objects
 is returned, taken from the specified MESSAGE or message HEAD.
 
 =back
diff -ru ../Mail-Box-2.054-orig/lib/Mail/Message.pod ./lib/Mail/Message.pod
--- ../Mail-Box-2.054-orig/lib/Mail/Message.pod	2004-02-06 12:47:18.000000000 -0800
+++ ./lib/Mail/Message.pod	2004-05-06 14:53:23.000000000 -0700
@@ -50,7 +50,7 @@
 A C<Mail::Message> object is a container for MIME-encoded message information,
 as defined by RFC2822.  Everything what is not specificly related to storing
 the messages in mailboxes (folders) is implemented in this class.  Methods
-which are are related to folders is implemented in the L<Mail::Box::Message|Mail::Box::Message>
+which are related to folders is implemented in the L<Mail::Box::Message|Mail::Box::Message>
 extension.
 
 The main methods are L<get()|Mail::Message/"The header">, to get information from a message header
@@ -1391,7 +1391,7 @@
 The header is a list of fields, some spanning more than one line
 (I<folded>) each telling something about the message. Information stored
 in here are for instance the sender of the message, the receivers of
-the message, when it was transported, how it was transported, etc etc.
+the message, when it was transported, how it was transported, etc.
 Headers can grow quite large.
 
 In MailBox, each message object manages exactly one header object
diff -ru ../Mail-Box-2.054-orig/Makefile.PL ./Makefile.PL
--- ../Mail-Box-2.054-orig/Makefile.PL	2004-02-06 12:43:27.000000000 -0800
+++ ./Makefile.PL	2004-05-06 14:55:03.000000000 -0700
@@ -49,7 +49,7 @@
 The wrapper to the Outlook's dbx files consists of a c-library
 named libdbx (website http://sorceforge.net/project/ol2mbox/),
 and a wrapper which is distributed separately from Mail::Box.
-You get read-only access to the the dbx folders.
+You get read-only access to the dbx folders.
 REASON
 
 , [ Mail::SpamAssassin => '2.00', reason  => <<'REASON', warning => <<'WARN' ]
diff -ru ../Mail-Box-2.054-orig/tests/Tools.pm ./tests/Tools.pm
--- ../Mail-Box-2.054-orig/tests/Tools.pm	2004-02-06 12:43:26.000000000 -0800
+++ ./tests/Tools.pm	2004-05-06 14:54:05.000000000 -0700
@@ -253,7 +253,7 @@
 }
 
 #
-# Strip message text down the the things which are the same on all
+# Strip message text down the things which are the same on all
 # platforms and all situations.
 #