Re: Harvester status for Marcus Denker

Hi Daniel, Marcus and all!

Daniel Vainsencher <[email protected]> wrote:
> I think Marcus has done more useful harvesting work in the last couple
> of days than most of us in N weeks.

Yup. :-)

> I'd say that Marcus can and should be trusted to approve stuff, except

Agree.

> for one thing - I haven't seen him post critical comments on any of the
> code he's reviewed, and for anyone that's going to be able to get stuff
> into the image where we all have to live with it, I want to know that he
> can be point out where code is lacking.

I am sure Marcus can do that too! :-) Personally I have found that the
code I have reviewed from others generally is good - but class comments
and method comments tend to lack IMHO.

I really want the quality of comments to be higher in the official
classes. I would personally never let classes in without class comments.

> Except for the selection aspect, this is also important because posting
> these public comments is the way knowledge is transmitted about good/bad
> practice, and not just to the author of the specific code.
> 
> What does everybody think?
> 
> Daniel

I definitely think Marcus should be a Harvester - if he likes to be one.
:-) Marcus is surely a more competent Squeaker than I am so... ;-)

regards, Göran
From [email protected] Mon Jun 09 13:57:56 2003
Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: (qmail 6260 invoked from network); 9 Jun 2003 13:57:56 -0000
Received: from iramx1.ira.uni-karlsruhe.de (141.3.10.80)
  by mail.theinternetone.net with SMTP; 9 Jun 2003 13:57:56 -0000
Received: from i09nbmarcus.atis.uni-karlsruhe.de ([141.3.8.99]
	helo=i09nbmarcus.ira.uka.de)
	by iramx1.ira.uni-karlsruhe.de with asmtp (Exim 3.30 #10 (Debian))
	id 19PN9n-0001cr-00; Mon, 09 Jun 2003 15:57:55 +0200
Received: from marcus by i09nbmarcus.ira.uka.de with local (Exim 3.33 #2
	(Debian))	id 19PNA6-0001Jb-00; Mon, 09 Jun 2003 15:58:14 +0200
Date: Mon, 9 Jun 2003 15:58:14 +0200
From: Marcus Denker <[email protected]>
To: [email protected]
Subject: Re: [Squeakfoundation]Harvester status for Marcus Denker
Message-ID: <[email protected]>
References: <[email protected]>
	<[email protected]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[email protected]>
User-Agent: Mutt/1.4.1i
cc: Discussing the Squeak Foundation
	<[email protected]>
X-BeenThere: [email protected]
X-Mailman-Version: 2.1
Precedence: list
Reply-To: Discussing the Squeak Foundation
	<[email protected]>
List-Id: Discussing the Squeak Foundation
 <squeakfoundation.lists.squeakfoundation.org>
List-Unsubscribe: <http://lists.squeakfoundation.org/listinfo/squeakfoundation>,
	<mailto:[email protected]?subject=unsubscribe>
List-Archive: <http://lists.squeakfoundation.org/pipermail/squeakfoundation>
List-Post: <mailto:[email protected]>
List-Help: <mailto:[email protected]?subject=help>
List-Subscribe: <http://lists.squeakfoundation.org/listinfo/squeakfoundation>,
	<mailto:[email protected]?subject=subscribe>
X-List-Received-Date: Mon, 09 Jun 2003 13:57:57 -0000

On Sun, Jun 08, 2003 at 10:40:28PM +0100, [email protected] wrote:
> > Except for the selection aspect, this is also important because posting
> > these public comments is the way knowledge is transmitted about good/bad
> > practice, and not just to the author of the specific code.
> > 
> > What does everybody think?
> > 
> > Daniel
> 
> I definitely think Marcus should be a Harvester - if he likes to be one.

Yes, there's lots of stuff to harvest and I'd like to help with that.

   Marcus


-- 
Marcus Denker [email protected]  -- Squeak! http://squeak.de