[phpldapadmin] [ phpldapadmin-Patches-3391039 ] Remove eval commands from PHP code

Patches item #3391039, was opened at 2011-08-14 04:16
Message generated for change (Comment added) made by wurley
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498548&aid=3391039&group_id=61828

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Roland Gruber (gruberroland)
Assigned to: Nobody/Anonymous (nobody)
Summary: Remove eval commands from PHP code

Initial Comment:
Hi Deon,

here is a patch to remove all "eval" commands from the PHP code. These commands are risky because it may be possible to inject code.
Although I cannot give you an example where this is possible at the moment, I recommend to remove them.

There are also JS eval commands that are not covered by this patch. Probably it would be an good idea to replace them, too.


Best regards

Roland

----------------------------------------------------------------------

>Comment By: Deon George (wurley)
Date: 2011-10-06 11:44

Message:
Thanks Roland.
Git commit #7fc4f0c

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498548&aid=3391039&group_id=61828

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
______________________________________
phpLDAPadmin development mailing list.
To unsbuscribe: https://lists.sourceforge.net/lists/listinfo/phpldapadmin-devel
http://phpldapadmin.sourceforge.net/