Re: Binarycloud php5 issues.
Bas Kamer <[email protected]> Thu, 27 Oct 2005 16:43:51 +0200
| Newsgroups | gmane.comp.lib.binarycloud.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============0090440197== Content-Type: multipart/alternative; boundary=Apple-Mail-1--354307059 --Apple-Mail-1--354307059 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Hi, does anyone see any obvious problem with this approach in the bc node tree? it does seem to work... and a check for the objects reveals they reference the same object... testsite does run, although a lot of E_STRICT message appear in the logs. this seems to affect the unittest to... (if message tests failes) b On Aug 26, 2005, at 12:55 AM, Rajesh Singh wrote: > Line 760 on node/Node.php with setting reference to top node is > 'causing a > bug. > > This line: > > $this->top =& $parent->top; > > Remove the &, change to: > > $this->top = $parent->top; > > As this appears to break PHP 5 and the way it handles referencing. > > Testsite, etc all seems to work pretty well with that change. --Apple-Mail-1--354307059 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=ISO-8859-1 <HTML><BODY style=3D"word-wrap: break-word; -khtml-nbsp-mode: space; = -khtml-line-break: after-white-space; ">Hi,<DIV><BR = class=3D"khtml-block-placeholder"></DIV><DIV><DIV><DIV>does anyone see = any obvious problem with this approach in the bc node = tree?=A0</DIV><DIV><BR class=3D"khtml-block-placeholder"></DIV><DIV>it = does seem to work... and a check for the objects=A0reveals they = reference the same object...</DIV><DIV><BR = class=3D"khtml-block-placeholder"></DIV><DIV>testsite does run, although = a lot of E_STRICT message appear in the logs. this seems to affect the = unittest to... (if message tests failes)</DIV><DIV><BR = class=3D"khtml-block-placeholder"></DIV><DIV>b</DIV><DIV><BR = class=3D"khtml-block-placeholder"></DIV><DIV>On Aug 26, 2005, at 12:55 = AM, Rajesh Singh wrote:</DIV><BR = class=3D"Apple-interchange-newline"><BLOCKQUOTE type=3D"cite"><DIV = style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px; = margin-left: 0px; ">Line 760 on node/Node.php with setting reference to = top node is 'causing a</DIV><DIV style=3D"margin-top: 0px; margin-right: = 0px; margin-bottom: 0px; margin-left: 0px; ">bug.</DIV><DIV = style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px; = margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style=3D"margin-top: = 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">This = line:</DIV><DIV style=3D"margin-top: 0px; margin-right: 0px; = margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV = style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px; = margin-left: 0px; ">$this->top =3D& $parent->top;</DIV><DIV = style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px; = margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style=3D"margin-top: = 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Remove = the &, change to:</DIV><DIV style=3D"margin-top: 0px; margin-right: = 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; = "><BR></DIV><DIV style=3D"margin-top: 0px; margin-right: 0px; = margin-bottom: 0px; margin-left: 0px; ">$this->top =3D = $parent->top;</DIV><DIV style=3D"margin-top: 0px; margin-right: 0px; = margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV = style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px; = margin-left: 0px; ">As this appears to break PHP 5 and the way it = handles referencing.<SPAN = class=3D"Apple-converted-space">=A0</SPAN></DIV><DIV style=3D"margin-top: = 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; = min-height: 14px; "><BR></DIV><DIV style=3D"margin-top: 0px; = margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Testsite, etc = all seems to work pretty well with that change.</DIV><BLOCKQUOTE = type=3D"cite"></BLOCKQUOTE></BLOCKQUOTE></DIV><FONT = class=3D"Apple-style-span" color=3D"#006312"><BR = class=3D"khtml-block-placeholder"></FONT></DIV></BODY></HTML>= --Apple-Mail-1--354307059-- --===============0090440197== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dev mailing list dev-PnctHDZWAvB/Cz2I37pSEPZ4XP/[email protected] http://lists.binarycloud.com/mailman/listinfo/dev --===============0090440197==--