Re: Binarycloud php5 issues.

Hi Bas,

Bas Kamer wrote:
> does anyone see any obvious problem with this approach in the bc node tree? 
> 
> it does seem to work... and a check for the objects reveals they
> reference the same object...
> 
> testsite does run, although a lot of E_STRICT message appear in the
> logs. this seems to affect the unittest to... (if message tests failes)

Are you sure php4 works with this ? and that this is really the same obj
referenced ? To my knowledge without & php4 makes a copy of the object.
Nethertheless I think I never use this reference to the top node ;-)

>> Remove the &, change to:
>>
>> $this->top = $parent->top;
>>
>> As this appears to break PHP 5 and the way it handles referencing. 
>>
>> Testsite, etc all seems to work pretty well with that change.

Sure, but afaik the & is necessary for php4.
Maybe we should start a svn branch for php5 specific corrections ?

-- 
Jean-Christophe Michel
_______________________________________________
dev mailing list
dev-PnctHDZWAvB/Cz2I37pSEPZ4XP/[email protected]
http://lists.binarycloud.com/mailman/listinfo/dev