[boost][int128] Formal Review Result

Dear Boost Community,

As Review Manager for Candidate Boost.Int128, I have carefully reviewed and
incorporated the community's feedback from July 22–31.

I decided to ACCEPT Boost.Int128 into Boost.

The library's well-defined scope, clear design, its excellent
documentation, its proven track record in the wild (including in
Boost.Decimal and in production codebases on multiple platforms, tested on
bare metal), the author's responsiveness throughout the review, and the
fact that all review issues/PRs have been tracked with the "Boost Review"
label, resolved (see:
https://github.com/cppalliance/int128/pulls?q=is%3Apr+is%3Aclosed+label%3A%22Boost+Review%22
 ), and merged on develop convinced me to accept the library.

Every reviewer who cast a formal vote recommended acceptance, and the only
conditional verdict rested on bugs that Matt resolved (and one feature
request he could not: https://github.com/cppalliance/int128/issues/485 ).

As for the details:

ACCEPT (7)
Rainer Deyke (July 27) (Undisclosed)
John Maddock (July 27) (Undisclosed)
Christopher Kormanyos (July 27) (collaborator with the author; not C++
Alliance)
Pavel Pavlov (July 28) (Undisclosed)
Peter Turcan (July 28) (C++ Alliance)
Jamie Allsop (August 1) (Undisclosed)
Nigel Stewart (August 1) (Undisclosed)

ACCEPT CONDITIONALLY (1)
Guillaume Dua (July 28–30) (Undisclosed)

COMMENTS / NOT A FORMAL REVIEW
Andrzej Krzemienski (August 2): on library-vs-builtin type semantics.
Various Reddit reviewers (eisenwave/WG21, James20k, MarekKnapek, and
others) contributed substantive technical feedback without a formal verdict.
Jarod on French Discord: contributed a bug report without a formal verdict.

NOTE:
I also note that several reviewers and commenters appreciated that the
library was available through a single-header aggregated file included by
Compiler Explorer, making it extremely easy to experiment with, stress the
implementation and review. I sincerely think this should become the norm,
not the exception for future (small-ish?) libraries. The cost of
aggregating the headers in CI is trivial and the benefit shows up in the
numerous latent bugs surfaced by reviewers.

CONCLUSION AND THANKS:
Congratulations to Matt Borland on an excellent contribution, and my
sincere thanks to everyone who took the time to review, test and debate. I
must insist that identifying all those bugs early will make life infinitely
easier for users and maintainers. Your time and effort are greatly
appreciated.

Have a wonderful week,

Best wishes,
Arnaud Becheler,
Review Manager for Boost.Int128 ... and hopeful future Review Manager for
Boost.256 ? ;)
_______________________________________________
Boost mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://lists.boost.org/mailman3/lists/boost.lists.boost.org/
Archived at: https://lists.boost.org/archives/list/[email protected]/message/MVOZZ7WKF5Q5BWI6LDMY4RMAABOZ6KCD/