Re: [PATCH] gl: use _cairo_gl_operand_copy to fix unblanced reference count
Chris Wilson <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <1338371309_353786@CP5-2952> |
On Wed, 30 May 2012 15:13:46 +0800, Yuanhan Liu <[email protected]> wrote: > Use _cairo_gl_operand_copy to do the operand copy instead of by > something like *operand = surface->operand. > > This would fix a crash introduced by operator-source test case, which > forgot to do reference while copying operand but did dereference while > destroying surface at combine_clip_as_traps(). > > Signed-off-by: Yuanhan Liu <[email protected]> I think for the case where we create and own the texture, the extra reference is superfluous, so I dropped it from this patch. Pushed, thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo