Re: [PATCH] gl: don't access ctx after release
Chris Wilson <[email protected]>
| Newsgroups | gmane.comp.lib.cairo |
|---|---|
| Message-ID | <1338372832_354213@CP5-2952> |
On Tue, 29 May 2012 14:33:40 +0800, Yuanhan Liu <[email protected]> wrote: > _cairo_gl_surface_map_to_image still access ctx->has_mesa_pack_invert after > release, which does't make sense. Conceptually you are right, and enforcing this does reduce the assumptions made by the code and keeps it clean. I didn't quite like how the function repeated the same checks, so I replaced those with locals to improve readibility further. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre -- cairo mailing list [email protected] http://lists.cairographics.org/mailman/listinfo/cairo