Re: [PATCH] xcb: Query the display's subpixel order via RENDER

Am 15.01.2015 um 04:22 schrieb Bryce Harrington:
> On Sat, Dec 06, 2014 at 05:10:33PM +0100, Uli Schlachter wrote:
>> Am 06.12.2014 um 16:13 schrieb Uli Schlachter:
>> [...]
>>> +static int _get_screen_index(cairo_xcb_connection_t *xcb_connection,
>>> +			     xcb_screen_t *xcb_screen)
>>> +{
>>> +    int idx = 0;
>>> +    xcb_screen_iterator_t iter = xcb_setup_roots_iterator(xcb_connection->root);
>>> +    for (; iter.rem; xcb_screen_next(&iter), idx++)
>>> +	if (iter.data == xcb_screen)
>>> +	    return idx;
>>> +
>>> +    ASSERT_NOT_REACHED;
>>> +}
>> [...]
>>
>> If only things were so easy...
>>
>> I changed the "if" in this function to:
>>
>>   if (iter.data->root == xcb_screen->root)
>>
>> The reason for this is left as an exercise for the reader.
>> Oh and I also have another, completely unrelated patch.
> 
> Hi Uli,
> 
> Both of these patches look fine to me.  Would you like me to test and
> land them, or are you hoping for further feedback first?
[...]

...or did I just forget about then. :-)

Both pushed, but sadly this new resources code still causes the same issues that
it originally caused and thus is still disabled.

Cheers,
Uli
-- 
- Captain, I think I should tell you I've never
  actually landed a starship before.
- That's all right, Lieutenant, neither have I.
-- 
cairo mailing list
[email protected]
http://lists.cairographics.org/mailman/listinfo/cairo