Re: [PATCH] sysdeps/x86: don't spuriously mark tests as xfail
Adhemerval Zanella Netto <[email protected]>
| Newsgroups | gmane.comp.lib.glibc.alpha |
|---|---|
| Organization | Linaro |
| Message-ID | <[email protected]> |
On 02/07/26 08:27, Andreas Schwab wrote: > Properly set xfail marker, $(with-lld) is always non-empty. LGTM, thanks. Reviewed-by: Adhemerval Zanella <[email protected]> > --- > sysdeps/x86/Makefile | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile > index b16f4a3404..232e388d32 100644 > --- a/sysdeps/x86/Makefile > +++ b/sysdeps/x86/Makefile > @@ -50,8 +50,10 @@ tests += \ > tests-static += \ > tst-ifunc-isa-1-static \ > # tests-static > -test-xfail-tst-ifunc-isa-1 = $(with-lld) > -test-xfail-tst-ifunc-isa-1-static = $(with-lld) > +ifneq (no, $(with-lld)) > +test-xfail-tst-ifunc-isa-1 = yes > +test-xfail-tst-ifunc-isa-1-static = yes > +endif > tests += \ > tst-ifunc-isa-2 \ > tst-ifunc-isa-2-static \ > @@ -59,8 +61,10 @@ tests += \ > tests-static += \ > tst-ifunc-isa-2-static \ > # tests-static > -test-xfail-tst-ifunc-isa-2 = $(with-lld) > -test-xfail-tst-ifunc-isa-2-static = $(with-lld) > +ifneq (no, $(with-lld)) > +test-xfail-tst-ifunc-isa-2 = yes > +test-xfail-tst-ifunc-isa-2-static = yes > +endif > endif > endif > ifeq (yes,$(enable-x86-isa-level))