Re: [PATCH 2/2] aarch64: Add workaround for GDB bug handling string literals

Hi Adhemerval,

> So I tried to implement this check and I had my assumptions wrong [1]: the
> ifunc resolution can also be called from libc (dlsym), there is the
> extra complication of static dlopen and dlmopen, and there also the
> valgrind case (elf/tst-valgrind-smoke regress).
>
> This heuristic cannot tell between "bad" issuing (gdb evaluating a call) from
> "good" (valgrind resolving for redirection), since valgrind dynamic translation
> regenerates ld.so/libc.so and thus with a different mappings.
>
> So I agree that we should focus on fixing gdb instead of adding extra hacks
> on glibc. I am not sure about reverting changes, it would be safer for this release.

Yes that's why I came up with a check that only looks at the given hwcap argument.
I think you suggested setting a boolean when resolving ifuncs. That would be a
simpler and safer approach IF we decide that no user application should ever call
a resolver directly.

Cheers,
Wilco