Re: [PATCH 1/2] RISC-V: Add memcpy, memmove, memset and strcmp implementations optimized for size.

Hi Ilia:

Just few minor comment:

1. There is some trailing white space in the patch, could you clean up that?

/home/users/kito/riscv-gnu-toolchain-workspace/riscv-gnu-toolchain/.git/modules/riscv-newlib/rebase-apply/patch:101:
trailing whitespace.
#if defined(PREFER_SIZE_OVER_SPEED) || defined(__OPTIMIZE_SIZE__)
/home/users/kito/riscv-gnu-toolchain-workspace/riscv-gnu-toolchain/.git/modules/riscv-newlib/rebase-apply/patch:117:
trailing whitespace.
2:
/home/users/kito/riscv-gnu-toolchain-workspace/riscv-gnu-toolchain/.git/modules/riscv-newlib/rebase-apply/patch:181:
trailing whitespace.
#if defined(PREFER_SIZE_OVER_SPEED) || defined(__OPTIMIZE_SIZE__)
/home/users/kito/riscv-gnu-toolchain-workspace/riscv-gnu-toolchain/.git/modules/riscv-newlib/rebase-apply/patch:205:
trailing whitespace.
2:
/home/users/kito/riscv-gnu-toolchain-workspace/riscv-gnu-toolchain/.git/modules/riscv-newlib/rebase-apply/patch:218:
trailing whitespace.
#if defined(PREFER_SIZE_OVER_SPEED) || defined(__OPTIMIZE_SIZE__)

2. Patch conflict with current master branch, seems like you forgot
rebase with trunk before send patch.

error: patch failed: newlib/libc/machine/riscv/memcpy.c:9
error: newlib/libc/machine/riscv/memcpy.c: patch does not apply


On Tue, May 21, 2019 at 7:30 AM <[email protected]> wrote:
>
> Thanks for you notice, Jim. Currently I cannot use git send-email, so I
> try to provide the patches in attachment.
>
> Jim Wilson писал 2019-05-20 16:09:
> > On Fri, May 17, 2019 at 4:53 PM <[email protected]> wrote:
> >> This patch adds implementations of memcpy, memmove, memset and strcmp
> >> optimized for size. The changes have been tested in
> >> riscv/riscv-gnu-toolchain by riscv-dejagnu with
> >> riscv-sim.exp/riscv-sim-nano.exp.
> >
> > The patch was corrupted by the mailer.   Long lines were line wrapped.
> > Lines that should have only a single space are now blank lines.  Line
> > that should start with one space now have two.  Using git send-email
> > should work better if you can use that.  Otherwise, you probably need
> > to include the patches as attachments instead of trying to insert the
> > text of the patch into an email.
> >
> > Optimitech is working on a contract for SiFive, so having the SiFive
> > name in the copyright statements is OK.  Though I don't mind if the
> > Optimitech name is in there too.
> >
> > I tested an earlier version of this (without the memmove-stub.c fix),
> > and it gets a thumbs up from me, though I'm not an official newlib
> > maintainer so can't approve it.
> >
> > Jim