Re: [PATCH 2/2] RISC-V: Add _LITE_EXIT in crt0.S.

Hi Illa:

This patch LGTM :)

Hi Jim:

Seems like it's time to bump newlib in riscv/riscv-gnu-toolchain, I'll
do that after this 2 patches apply :)

On Tue, May 21, 2019 at 5:12 AM Jim Wilson <[email protected]> wrote:
>
> On Fri, May 17, 2019 at 4:53 PM <[email protected]> wrote:
> > This patch adds _LITE_EXIT in crt0.S to enable "lite exit" technique in
> > RISC-V. The changes have been tested in riscv/riscv-gnu-toolchain by
> > riscv-dejagnu with riscv-sim.exp/riscv-sim-nano.exp.
>
> Same comments as first part of the patch set.
>
> Personally, I'd put the .Lweak_atexit label inside _LITE_EXT ifdefs,
> but this matches the way that the ARM port does it, so should be OK
> also.
>
> To be fully effective, this requires build script changes to the
> github riscv/riscv-gnu-toolchain project, which will be handled as a
> separate patch.
>
> Jim