Re: [PATCH] Include "xlocale.h", not <xlocale.h>.

Hi Michael,

On Jun 11 19:43, Michael Haubenwallner wrote:
> libX11 does provide an <X11/Xlocale.h>, and while building libX11
> itself, they add their include/X11 to the compiler's include path.
> Now when newlib headers include <xlocale.h> on the case insensitive
> file system, the compiler does pick their Xlocale.h.
> So we better include "xlocale.h" in newlib headers instead, to prefer
> newlib xlocale.h from within newlib headers.

Commit 90e35b1eb3df renamed _locale.h to xlocale.h in March 2017 under
the assumption that we should provide the locale_t type in the same file
as on Linux, FreeBSD, and Darwin.

A few weeks later (June 2017), glibc removed the xlocale.h file in favor
of bits/types/locale_t.h, which shouldn't be included directly anyway.

For reference and the reasoning, see
https://sourceware.org/git/?p=glibc.git;a=commit;h=f0be25b6336d

Given that glibc and thus Linux stopped providing the non-standard
xlocale.h header, I'd favor reverting 90e35b1eb3df.


Thoughts?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAl0AsjEACgkQ9TYGna5E
T6AxVg//VXA/5b733smgd+53RnI5bspHIzVxaS7mWxFAPMPM0/HzlX6jYw2ShQI4
xm7d+XJwzGqZWbbwphqCiGjwwOYQKlomuxAauiOB4zzVFjQXeuY25qPsN319TsVz
TYMN3+UiTg8m3T5qYWmvfo5sFnL8giYszqWYxBalGNWWKfGO/S1TExWJeXg1aVpQ
3/8Xiew1yBSMlfZV+t12GL/gSpoG3R64nAWgI7kh5Q1kP9i07Bh0xVaBkuo6KPdJ
nrqBkkh9rGCmNvmpvayMRQhg6MPqyr0Z9zgdIfh7/H/QKNDQz0p68BfKtKYHkMqO
V72nY9RC1Ki1LGqNIC+qzP1283v06Py+SWr3F2QDos6tkE+VUyrLdXfxFb/3Liab
SdMMAkwiuPkclqvBkSgptfW64GffYDkdVDHFLg/Wme8EKMehTfW34XTP1lVRZxIt
Q5ovNR0+iX8d+lE35P9gqDDqE0KWSn2wGsZb1adxgmA8U5ykwkKoegy9ryM52+1n
tNTJXCZWlYMkCLoewyO07GQxvYFXr+KGEe72iCorJ1cKtXzSRKUSRbHpf4CZei+x
TnrDn/mqlCvJX5TIiqhN+UVBcY0dfTRmJk0k3Vmev59fivt+1iIwfQS8cDn6S49N
sATiB4bVGl+KJDjVpIsI11qnMUK1ESPXztTDfjC+a/FQxwy6KGQ=
=dAQF
-----END PGP SIGNATURE-----