Re: [PATCH] Include "xlocale.h", not <xlocale.h>.

Michael Haubenwallner <[email protected]> Wed, 12 Jun 2019 10:27:59 +0200

Newsgroups	gmane.comp.lib.newlib
Message-ID	<[email protected]>

Hi Corinna,

On 6/12/19 10:05 AM, Corinna Vinschen wrote:
> Hi Michael,
> 
> On Jun 11 19:43, Michael Haubenwallner wrote:
>> libX11 does provide an <X11/Xlocale.h>, and while building libX11
>> itself, they add their include/X11 to the compiler's include path.
>> Now when newlib headers include <xlocale.h> on the case insensitive
>> file system, the compiler does pick their Xlocale.h.
>> So we better include "xlocale.h" in newlib headers instead, to prefer
>> newlib xlocale.h from within newlib headers.
> 
> Commit 90e35b1eb3df renamed _locale.h to xlocale.h in March 2017 under
> the assumption that we should provide the locale_t type in the same file
> as on Linux, FreeBSD, and Darwin.
> 
> A few weeks later (June 2017), glibc removed the xlocale.h file in favor
> of bits/types/locale_t.h, which shouldn't be included directly anyway.
> 
> For reference and the reasoning, see
> https://sourceware.org/git/?p=glibc.git;a=commit;h=f0be25b6336d
> 
> Given that glibc and thus Linux stopped providing the non-standard
> xlocale.h header, I'd favor reverting 90e35b1eb3df.

Fine with me as well!

Thanks!
/haubi/

signature.asc (application/pgp-signature, 981 B)