Re: [PATCH] Auto-generated files for commit e6ce6f1430eee503a388cf1fc7fe6634de09fb0f
Eshan Dhawan via Newlib <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <CAH5ZSWp8g=teF4QaseSr-GMEczUWs+-P0edRciHoSV2a87oqJg@mail.gmail.com> |
Hi jeff This patch changes nothing, other than adding the autoconf files. -Eshan On Wed, Jun 10, 2020 at 2:00 AM Jeff Johnston <[email protected]> wrote: > Hi Eshan, > > Typically, you do not run autotools for newllib patches. I or Corinne > will do that for you so if this patch has not changed from the one you > submitted > without autoconf files, then I'll just regenerate the files for you and > amend the patch. > > --- Jeff J. > > On Tue, Jun 9, 2020 at 5:28 AM Sebastian Huber < > [email protected]> wrote: > >> On 09/06/2020 10:56, Eshan Dhawan wrote: >> >> > >> > On Tue, Jun 9, 2020 at 10:27 AM Sebastian Huber >> > <[email protected] >> > <mailto:[email protected]>> wrote: >> > >> > On 08/06/2020 08:06, Eshan Dhawan wrote: >> > >> > >>> On 08-Jun-2020, at 10:40 AM, Sebastian >> > Huber<[email protected] >> > <mailto:[email protected]>> wrote: >> > >>> >> > >>> On 07/06/2020 19:42, Eshan dhawan wrote: >> > >>> >> > >>> diff --git a/newlib/configure b/newlib/configure >> > >>> index d6c3372d8..4e0125101 100755 >> > >>> --- a/newlib/configure >> > >>> +++ b/newlib/configure >> > >>> @@ -1,11 +1,9 @@ >> > >>> #! /bin/sh >> > >>> # Guess values for system-dependent variables and create >> > Makefiles. >> > >>> -# Generated by GNU Autoconf 2.68 for newlib 3.3.0. >> > >>> +# Generated by GNU Autoconf 2.69 for newlib 3.3.0. >> > >>> # >> > >> If you use the wrong Autoconf/Automake versions to regenerate >> > the files, then the universe may collapse. >> > > I have tested the patches and it works completely fine with >> > these versions as well. >> > >> > With how many Newlib targets and host systems have you tested this >> > change? Are you really confident enough to change the top-level >> > configure file of Newlib through an unrelated side-effect of a >> > powerpc >> > fenv support patch? >> > >> > Please regenerate the files with the right Automake/Autoconf >> versions >> > and reduce the impact of your patch. >> > >> > Ok, I will regenerate the patch. >> > Could you please tell me the correct versions to be used, >> I don't know this for sure, but I guess it is Autoconf 2.68 if you look >> a couple of lines above. >> >>