[PATCH] riscv: fix integer wraparound in memcpy
PkmX via Newlib <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <CACSh3m3euJOWd94oEpV6MWUUqm4Ehg3bt_x4y-HZTX0j=qZs7w@mail.gmail.com> |
This patch fixes a bug in RISC-V's memcpy implementation where an integer wraparound occurs when src + size < 8 * sizeof(long), causing the word-sized copy loop to be incorrectly entered. Signed-off-by: Chih-Mao Chen <[email protected]> --- newlib/libc/machine/riscv/memcpy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/newlib/libc/machine/riscv/memcpy.c b/newlib/libc/machine/riscv/memcpy.c index 07e8e0076..4098f3ab1 100644 --- a/newlib/libc/machine/riscv/memcpy.c +++ b/newlib/libc/machine/riscv/memcpy.c @@ -51,9 +51,9 @@ small: const long *lb = (const long *)b; long *lend = (long *)((uintptr_t)end & ~msk); - if (unlikely (la < (lend - 8))) + if (unlikely (lend - la > 8)) { - while (la < (lend - 8)) + while (lend - la > 8) { long b0 = *lb++; long b1 = *lb++; -- 2.27.0