Re: [PATCH 0/2] Fix fenv support for ARM

Corinna Vinschen via Newlib <[email protected]>
Newsgroups gmane.comp.lib.newlib
Message-ID <[email protected]>
On Jul 23 07:13, Sebastian Huber wrote:
> On 19/07/2020 13:01, Sebastian Huber wrote:
> 
> > This patch set addresses some issues which popped up while building Newlib for
> > ARM with GCC 10 which enables -fno-common by default.
> > 
> > Eshan dhawan (1):
> >    arm: Fix fenv support
> > 
> > Sebastian Huber (1):
> >    arm: Remove superfluous fenv stub files
> 
> I just noticed that the stub files I removed are not superfluous. Its seems
> they are necessary to somehow overwrite the default implementations in:
> 
> newlib/libm/fenv
> 
> There seems to be some build system magic involved here. I guess we have to
> split up fenv.c and move all the functions to individual files matching the
> ones in newlib/libm/fenv?

Splitting is probably better.  When you created and tested a new patchset,
feel free to push it.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.