Re: [PATCH] libc: Replace i386/sys/fenv.h symlink with an #include shim

Corinna Vinschen via Newlib <[email protected]>
Newsgroups gmane.comp.lib.newlib
Message-ID <[email protected]>
On Mar  9 20:11, David Macek via Newlib wrote:
> On Mon, Mar 8, 2021 at 11:00 AM Corinna Vinschen <[email protected]> wrote:
> > This doesn't work.  The machine-specific header will get installed to
> > $DESTDIR/usr/include/sys/fenv.h, and it will now include a non-existing
> > file.  We have to keep the symlink or to duplicate the file.
> 
> How come the newlib/libm/machine/i386/fenv.c non-symlink works?  Is it
> installed differently?

It's not installed at all.  It's a source file so the include only has
to work at build time.  The header file on the other hand will be
installed on the target.  As such, the result has to work on the target.

> Coincidentally, is newlib/libc/machine/ft32/stpcmp.S file correct?

I have no idea, you have to ask the guys knowing that chip type.


Corinna
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.