Re: [PATCH] libc: Replace i386/sys/fenv.h symlink with an #include shim

> > > This doesn't work.  The machine-specific header will get installed to
> > > $DESTDIR/usr/include/sys/fenv.h, and it will now include a non-existing
> > > file.  We have to keep the symlink or to duplicate the file.
> >
> > How come the newlib/libm/machine/i386/fenv.c non-symlink works?  Is it
> > installed differently?
>
> It's not installed at all.  It's a source file so the include only has
> to work at build time.  The header file on the other hand will be
> installed on the target.  As such, the result has to work on the target.

Ah, right.  But then I'm confused how a symlink can work in the first
place.  I guess some part of the build process copies the contents
instead of the file.

More to the point, how big of an issue would be to duplicate the file?

> > Coincidentally, is newlib/libc/machine/ft32/stpcmp.S file correct?
>
> I have no idea, you have to ask the guys knowing that chip type.

I didn't read the instructions, it's just the label looks wrong. :)
Should I start another thread?

-- 
David Macek