Re: [PATCH] clang compatibility: use p2align
"Richard Earnshaw (lists)" <[email protected]>
| Newsgroups | gmane.comp.lib.newlib |
|---|---|
| Message-ID | <[email protected]> |
On 20/01/2025 15:29, Volodymyr Turanskyy wrote: > Hi, > > > > Please see attached re-formatted patch file. > > > > Sincerely, > > > > *Volodymyr Turanskyy* | Principal Software Engineer | CE SW LLVM Team > > > > *From: *Joel Sherrill <[email protected]> > *Date: *Monday, 20 January 2025 at 14:58 > *To: *Volodymyr Turanskyy <[email protected]> > *Cc: *[email protected] <[email protected]>, nd <[email protected]> > *Subject: *Re: [PATCH] clang compatibility: use p2align > > The patch looks ok but it does not have a commit message. git format-patch should do the trick. > > > > I have a meeting in 2 minutes and can't look at the other two right now. > > > > --joel > > > > On Mon, Jan 20, 2025 at 8:49 AM Volodymyr Turanskyy <[email protected] <mailto:[email protected]>> wrote: > > Hi, > > > > Following up on the RFC [1], please find attached a patch that uses p2aling since as per https://www.sourceware.org/binutils/docs/as/ARM-Directives.html <https://www.sourceware.org/binutils/docs/as/ARM-Directives.html> GCC .align 0 is a special case that actually means .p2align 2 which is explicit and handled by clang. > > > > References > > 1. https://sourceware.org/pipermail/newlib/2025/021452.html <https://sourceware.org/pipermail/newlib/2025/021452.html> > > > > > > Sincerely, > > > > *Volodymyr Turanskyy* | Principal Software Engineer | CE SW LLVM Team > Pushed, thanks. R.