Re: [PATCH] clang compatibility: fpu options

On 20/01/2025 15:29, Volodymyr Turanskyy wrote:
> Hi,
> 
>  
> 
> Please see attached re-formatted patch file.
> 
>  
> 
> Sincerely,
> 
>  
> 
> *Volodymyr Turanskyy* | Principal Software Engineer | CE SW LLVM Team
> 
>  
> 
> *From: *Volodymyr Turanskyy <[email protected]>
> *Date: *Monday, 20 January 2025 at 15:06
> *To: *Joel Sherrill <[email protected]>, [email protected] <[email protected]>
> *Cc: *nd <[email protected]>
> *Subject: *Re: [PATCH] clang compatibility: fpu options
> 
> Hi Joel,
> 
>  
> 
> Let me fix the commit messages.
> 
>  
> 
> Clang does not have vfpxd - vfpv3xd might be the closest, however we believe that it is not needed for clang at all, so it is skipped.
> 
>  
> 
> Sincerely,
> 
>  
> 
> *Volodymyr Turanskyy* | Principal Software Engineer | CE SW LLVM Team
> 
>  
> 
> *From: *Joel Sherrill <[email protected]>
> *Date: *Monday, 20 January 2025 at 15:01
> *To: *Volodymyr Turanskyy <[email protected]>
> *Cc: *[email protected] <[email protected]>, nd <[email protected]>
> *Subject: *Re: [PATCH] clang compatibility: fpu options
> 
> Same with missing commit.
> 
>  
> 
> Does the clang assembler have a directive for vfpxd? If I am reading the patch correctly, it just drops the directive rather than replacing it.
> 
>  
> 
> --joel
> 
>  
> 
> On Mon, Jan 20, 2025 at 8:49 AM Volodymyr Turanskyy <[email protected] <mailto:[email protected]>> wrote:
> 
>     Hi,
> 
>      
> 
>     Following up on the RFC [1], please find attached a patch that adds a check to avoid extra assembler directives that are not compatible with clang and are not needed by clang.
> 
>      
> 
>     References
> 
>     https://sourceware.org/pipermail/newlib/2025/021452.html <https://sourceware.org/pipermail/newlib/2025/021452.html>
> 
>      
> 
>     Sincerely,
> 
>      
> 
>     *Volodymyr Turanskyy* | Principal Software Engineer | CE SW LLVM Team
> 

Pushed, thanks.

VFPxd is a pseudo VFP implementation that represents the common subset of VFP1 and VFP3xd.  It's useful for this sort of scenario where we want the generated code to be compatible with multiple compilation options.

R.