Re: Major change to osis2mod - Module, NT & OT introductions and bug fixes
Greg Hellings <[email protected]> Fri, 8 Aug 2025 15:15:17 -0500
| Newsgroups | gmane.comp.literature.sword.devel |
|---|---|
| Message-ID | <CAHxvOVJS_LfkU_QVihVJu8uJObte_sMuD2t6Hse-pL7iK7oRZA@mail.gmail.com> |
--===============4996009205878529078== Content-Type: multipart/alternative; boundary="00000000000029d28a063be03ce5" --00000000000029d28a063be03ce5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable New builds with your latest change included for Windows: https://src.thehellings.com/greg/mingw-sword-build/-/releases/2025.08.08.90= 66dcfe --Greg On Fri, Aug 8, 2025 at 1:45=E2=80=AFPM DM Smith <[email protected]> wro= te: > No, not at all. For a verse, it can use the osisID, say Matt.1 for the > sID/eID > <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D> =E2=80=A6. </chapter> > becomes > <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D sID=3D=E2=80=9CMatt.1"/>=E2=80= =A6 <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D > eID=3D=E2=80=9CMatt.1"/> > rather than: > <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D sID=3D=E2=80=9C genNNNNNN/>=E2= =80=A6 <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D > eID=3D=E2=80=9CgenNNNNNN"/> > > On Aug 8, 2025, at 2:21=E2=80=AFPM, David Haslam <dfhdfh-g/[email protected]> = wrote: > > Hi DM, > > Does the last description imply that we are doing away completely with th= e > *milestone* versions of *osisID* elements? > > If that's the case, does this overlook a fundamental reason why they were > introduced in the first place? > > Does this change warrant some edits to the relevant page in the > developers' wiki ? > > Best regards, > > David > > Sent with Proton Mail <https://pr.tn/ref/SWXT9A5YZ67G> secure email. > > > On Friday, August 8th, 2025 at 5:29 PM, DM Smith [email protected] > wrote: > > > I just checked in the following: > > MODTOOLS-111 osis2mod - Added module and testament introductions. > * Made div of type bookGroup or book the demarcation between Module > Introduction and module content. > * From John Austin, changed the demarcation of chapter introductions and > pre-verse, > from a section div to a section, subSection or majorSection div when the > subType isn't x-introduction. > ** MODTOOLS-94 subSection pre-verse titles are not recognized > ** MODTOOLS-95 majorSection titles are not always imported properly- and > sometimes drops text > * Removed old commented out code for majorSection > * Added two more exit codes EXIT_BAD_COMMENT and EXIT_BAD_ENTITY to > replace misuse of EXIT_BAD_NESTING. > * Reformatted diagnostic messages to be more readable. > * Used global v11n rather than calling > currentVerse.getVersificationSystem(). > * Changed 1 and 0 to true and false where the argument is bool. > * If the module has module or testament introductions, prepend the > revision to the first one, otherwise do as before. > * Fixed bug where New Testament content is appended to Malachi. > ** MODTOOLS-4 osis2mod: bug in handling preverse material > ** MODTOOLS-8 osis2mod does not place the New Testament bookGroup title i= n > the correct place > ** MODTOOLS-93 New Testament introduction is appended to end of Malachi > * Rather than generating an sID/eID pair for book, chapter or verse, use > the osisID value. > * updated osis testcases to pass > _______________________________________________ > sword-devel mailing list: [email protected] > http://crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page > > _______________________________________________ > sword-devel mailing list: [email protected] > http://crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page > > > _______________________________________________ > sword-devel mailing list: [email protected] > http://crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page > --00000000000029d28a063be03ce5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>New builds with your latest change included for Windo= ws:=C2=A0<a href=3D"https://src.thehellings.com/greg/mingw-sword-build/-/re= leases/2025.08.08.9066dcfe">https://src.thehellings.com/greg/mingw-sword-bu= ild/-/releases/2025.08.08.9066dcfe</a></div><div><br></div><div>--Greg</div= ></div><br><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr= " class=3D"gmail_attr">On Fri, Aug 8, 2025 at 1:45=E2=80=AFPM DM Smith <= <a href=3D"mailto:[email protected]">[email protected]</a>> wrot= e:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0= .8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>No, not = at all. For a verse, it can use the osisID, say Matt.1 for the sID/eID<div>= <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D> =E2=80=A6. </chapter&g= t;</div><div>becomes</div><div><chapter osisID=3D=E2=80=9CMatt.1=E2=80= =9D sID=3D=E2=80=9CMatt.1"/>=E2=80=A6 <chapter osisID=3D=E2=80= =9CMatt.1=E2=80=9D eID=3D=E2=80=9CMatt.1"/></div><div>rather than:<= /div><div><chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D sID=3D=E2=80=9C=C2= =A0genNNNNNN/>=E2=80=A6 <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D eI= D=3D=E2=80=9CgenNNNNNN"/><br id=3D"m_3276596390392875119lineBreakAt= BeginningOfMessage"><div><br><blockquote type=3D"cite"><div>On Aug 8, 2025,= at 2:21=E2=80=AFPM, David Haslam <<a href=3D"mailto:[email protected]= om" target=3D"_blank">dfhdfh-g/[email protected]</a>> wrote:</div><br><div><d= iv style=3D"font-family:Arial,sans-serif;font-size:14px"><p>Hi DM,</p><p>Do= es the last description imply that we are doing away completely with the <b= >milestone</b> versions of <b>osisID</b> elements?</p><p> If that's the case, does this overlook a fundamental reason why they we= re introduced in the first place?<br><br>Does this change warrant some edit= s to the relevant page in the developers' wiki ?<br> <br> </p><div style=3D"font-family:Arial,sans-serif;font-size:14px"> <div> Best regards,<br><br>David </div> <div style=3D"font-family:Arial,sans-serif;font-size:14px"><br></div> <div> Sent with <a href=3D"https://pr.tn/ref/SWXT9A5YZ67G" target=3D"_bla= nk">Proton Mail</a> secure email. </div> </div> <br> <br> On Friday, August 8th, 2025 at 5:29 PM, DM Smith <a href=3D"mailto:dmsmith@= crosswire.org" target=3D"_blank">[email protected]</a> wrote:<div><br><= /div><div><br></div> <blockquote><p>I just checked in the following:</p><p>MODTOOLS-111 osis2mod= - Added module and testament introductions.<br> * Made div of type bookGroup or book the demarcation between Module Introdu= ction and module content.<br> * From John Austin, changed the demarcation of chapter introductions and pr= e-verse,<br> from a section div to a section, subSection or majorSection div when the su= bType isn't x-introduction.<br> ** MODTOOLS-94 subSection pre-verse titles are not recognized<br> ** MODTOOLS-95 majorSection titles are not always imported properly- and so= metimes drops text<br> * Removed old commented out code for majorSection<br> * Added two more exit codes EXIT_BAD_COMMENT and EXIT_BAD_ENTITY to replace= misuse of EXIT_BAD_NESTING.<br> * Reformatted diagnostic messages to be more readable.<br> * Used global v11n rather than calling currentVerse.getVersificationSystem(= ).<br> * Changed 1 and 0 to true and false where the argument is bool.<br> * If the module has module or testament introductions, prepend the revision= to the first one, otherwise do as before.<br> * Fixed bug where New Testament content is appended to Malachi.<br> ** MODTOOLS-4 osis2mod: bug in handling preverse material<br> ** MODTOOLS-8 osis2mod does not place the New Testament bookGroup title in = the correct place<br> ** MODTOOLS-93 New Testament introduction is appended to end of Malachi<br> * Rather than generating an sID/eID pair for book, chapter or verse, use th= e osisID value.<br> * updated osis testcases to pass<br> _______________________________________________<br> sword-devel mailing list: <a href=3D"mailto:[email protected]" targ= et=3D"_blank">[email protected]</a><br> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" target=3D"_bl= ank">http://crosswire.org/mailman/listinfo/sword-devel</a><br> Instructions to unsubscribe/change your settings at above page</p> </blockquote></div>_______________________________________________<br>sword= -devel mailing list: <a href=3D"mailto:[email protected]" target=3D= "_blank">[email protected]</a><br><a href=3D"http://crosswire.org/m= ailman/listinfo/sword-devel" target=3D"_blank">http://crosswire.org/mailman= /listinfo/sword-devel</a><br>Instructions to unsubscribe/change your settin= gs at above page<br></div></blockquote></div><br></div></div>______________= _________________________________<br> sword-devel mailing list: <a href=3D"mailto:[email protected]" targ= et=3D"_blank">[email protected]</a><br> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" rel=3D"norefe= rrer" target=3D"_blank">http://crosswire.org/mailman/listinfo/sword-devel</= a><br> Instructions to unsubscribe/change your settings at above page<br> </blockquote></div> --00000000000029d28a063be03ce5-- --===============4996009205878529078== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ sword-devel mailing list: [email protected] http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page --===============4996009205878529078==--