Re: Major change to osis2mod - Module, NT & OT introductions and bug fixes
DM Smith <[email protected]> Fri, 8 Aug 2025 16:59:49 -0400
| Newsgroups | gmane.comp.literature.sword.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============4160035183394064634== Content-Type: multipart/alternative; boundary="Apple-Mail=_933F3EF8-7724-4BDB-A049-FB9DC859D1DD" --Apple-Mail=_933F3EF8-7724-4BDB-A049-FB9DC859D1DD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Many thanks! > On Aug 8, 2025, at 4:15=E2=80=AFPM, Greg Hellings = <[email protected]> wrote: >=20 > New builds with your latest change included for Windows: = https://src.thehellings.com/greg/mingw-sword-build/-/releases/2025.08.08.9= 066dcfe >=20 > --Greg >=20 > On Fri, Aug 8, 2025 at 1:45=E2=80=AFPM DM Smith <[email protected] = <mailto:[email protected]>> wrote: >> No, not at all. For a verse, it can use the osisID, say Matt.1 for = the sID/eID >> <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D> =E2=80=A6. </chapter> >> becomes >> <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D sID=3D=E2=80=9CMatt.1"/>=E2=80= =A6 <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D eID=3D=E2=80=9CMatt.1"/> >> rather than: >> <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D sID=3D=E2=80=9C = genNNNNNN/>=E2=80=A6 <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D = eID=3D=E2=80=9CgenNNNNNN"/> >>=20 >>> On Aug 8, 2025, at 2:21=E2=80=AFPM, David Haslam = <dfhdfh-g/[email protected] <mailto:dfhdfh-g/[email protected]>> wrote: >>>=20 >>> Hi DM, >>>=20 >>> Does the last description imply that we are doing away completely = with the milestone versions of osisID elements? >>>=20 >>> If that's the case, does this overlook a fundamental reason why they = were introduced in the first place? >>>=20 >>> Does this change warrant some edits to the relevant page in the = developers' wiki ? >>>=20 >>>=20 >>> Best regards, >>>=20 >>> David >>>=20 >>> Sent with Proton Mail <https://pr.tn/ref/SWXT9A5YZ67G> secure email. >>>=20 >>>=20 >>> On Friday, August 8th, 2025 at 5:29 PM, DM Smith = [email protected] <mailto:[email protected]> wrote: >>>=20 >>>=20 >>> I just checked in the following: >>>=20 >>> MODTOOLS-111 osis2mod - Added module and testament introductions. >>> * Made div of type bookGroup or book the demarcation between Module = Introduction and module content. >>> * =46rom John Austin, changed the demarcation of chapter = introductions and pre-verse, >>> from a section div to a section, subSection or majorSection div when = the subType isn't x-introduction. >>> ** MODTOOLS-94 subSection pre-verse titles are not recognized >>> ** MODTOOLS-95 majorSection titles are not always imported properly- = and sometimes drops text >>> * Removed old commented out code for majorSection >>> * Added two more exit codes EXIT_BAD_COMMENT and EXIT_BAD_ENTITY to = replace misuse of EXIT_BAD_NESTING. >>> * Reformatted diagnostic messages to be more readable. >>> * Used global v11n rather than calling = currentVerse.getVersificationSystem(). >>> * Changed 1 and 0 to true and false where the argument is bool. >>> * If the module has module or testament introductions, prepend the = revision to the first one, otherwise do as before. >>> * Fixed bug where New Testament content is appended to Malachi. >>> ** MODTOOLS-4 osis2mod: bug in handling preverse material >>> ** MODTOOLS-8 osis2mod does not place the New Testament bookGroup = title in the correct place >>> ** MODTOOLS-93 New Testament introduction is appended to end of = Malachi >>> * Rather than generating an sID/eID pair for book, chapter or verse, = use the osisID value. >>> * updated osis testcases to pass >>> _______________________________________________ >>> sword-devel mailing list: [email protected] = <mailto:[email protected]> >>> http://crosswire.org/mailman/listinfo/sword-devel >>> Instructions to unsubscribe/change your settings at above page >>>=20 >>> _______________________________________________ >>> sword-devel mailing list: [email protected] = <mailto:[email protected]> >>> http://crosswire.org/mailman/listinfo/sword-devel >>> Instructions to unsubscribe/change your settings at above page >>=20 >> _______________________________________________ >> sword-devel mailing list: [email protected] = <mailto:[email protected]> >> http://crosswire.org/mailman/listinfo/sword-devel >> Instructions to unsubscribe/change your settings at above page > _______________________________________________ > sword-devel mailing list: [email protected] > http://crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page --Apple-Mail=_933F3EF8-7724-4BDB-A049-FB9DC859D1DD Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"content-type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;">Many = thanks!<br id=3D"lineBreakAtBeginningOfMessage"><div><br><blockquote = type=3D"cite"><div>On Aug 8, 2025, at 4:15=E2=80=AFPM, Greg Hellings = <[email protected]> wrote:</div><br = class=3D"Apple-interchange-newline"><div><div dir=3D"ltr"><div>New = builds with your latest change included for Windows: <a = href=3D"https://src.thehellings.com/greg/mingw-sword-build/-/releases/2025= .08.08.9066dcfe">https://src.thehellings.com/greg/mingw-sword-build/-/rele= ases/2025.08.08.9066dcfe</a></div><div><br></div><div>--Greg</div></div><b= r><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" = class=3D"gmail_attr">On Fri, Aug 8, 2025 at 1:45=E2=80=AFPM DM Smith = <<a href=3D"mailto:[email protected]">[email protected]</a>>= wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px = 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex"><div>No, not at all. For a verse, it = can use the osisID, say Matt.1 for the sID/eID<div><chapter = osisID=3D=E2=80=9CMatt.1=E2=80=9D> =E2=80=A6. = </chapter></div><div>becomes</div><div><chapter = osisID=3D=E2=80=9CMatt.1=E2=80=9D sID=3D=E2=80=9CMatt.1"/>=E2=80=A6 = <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D = eID=3D=E2=80=9CMatt.1"/></div><div>rather than:</div><div><chapter = osisID=3D=E2=80=9CMatt.1=E2=80=9D sID=3D=E2=80=9C genNNNNNN/>=E2=80= =A6 <chapter osisID=3D=E2=80=9CMatt.1=E2=80=9D = eID=3D=E2=80=9CgenNNNNNN"/><br = id=3D"m_3276596390392875119lineBreakAtBeginningOfMessage"><div><br><blockq= uote type=3D"cite"><div>On Aug 8, 2025, at 2:21=E2=80=AFPM, David Haslam = <<a href=3D"mailto:dfhdfh-g/[email protected]" = target=3D"_blank">dfhdfh-g/[email protected]</a>> = wrote:</div><br><div><div = style=3D"font-family:Arial,sans-serif;font-size:14px"><p>Hi = DM,</p><p>Does the last description imply that we are doing away = completely with the <b>milestone</b> versions of <b>osisID</b> = elements?</p><p> If that's the case, does this overlook a fundamental reason why they = were introduced in the first place?<br><br>Does this change warrant some = edits to the relevant page in the developers' wiki ?<br> <br> </p><div style=3D"font-family:Arial,sans-serif;font-size:14px"> <div> Best regards,<br><br>David </div> <div style=3D"font-family:Arial,sans-serif;font-size:14px"><br></div> <div> Sent with <a href=3D"https://pr.tn/ref/SWXT9A5YZ67G" = target=3D"_blank">Proton Mail</a> secure email. </div> </div> <br> <br> On Friday, August 8th, 2025 at 5:29 PM, DM Smith <a = href=3D"mailto:[email protected]" = target=3D"_blank">[email protected]</a> = wrote:<div><br></div><div><br></div> <blockquote><p>I just checked in the following:</p><p>MODTOOLS-111 = osis2mod - Added module and testament introductions.<br> * Made div of type bookGroup or book the demarcation between Module = Introduction and module content.<br> * =46rom John Austin, changed the demarcation of chapter introductions = and pre-verse,<br> from a section div to a section, subSection or majorSection div when the = subType isn't x-introduction.<br> ** MODTOOLS-94 subSection pre-verse titles are not recognized<br> ** MODTOOLS-95 majorSection titles are not always imported properly- and = sometimes drops text<br> * Removed old commented out code for majorSection<br> * Added two more exit codes EXIT_BAD_COMMENT and EXIT_BAD_ENTITY to = replace misuse of EXIT_BAD_NESTING.<br> * Reformatted diagnostic messages to be more readable.<br> * Used global v11n rather than calling = currentVerse.getVersificationSystem().<br> * Changed 1 and 0 to true and false where the argument is bool.<br> * If the module has module or testament introductions, prepend the = revision to the first one, otherwise do as before.<br> * Fixed bug where New Testament content is appended to Malachi.<br> ** MODTOOLS-4 osis2mod: bug in handling preverse material<br> ** MODTOOLS-8 osis2mod does not place the New Testament bookGroup title = in the correct place<br> ** MODTOOLS-93 New Testament introduction is appended to end of = Malachi<br> * Rather than generating an sID/eID pair for book, chapter or verse, use = the osisID value.<br> * updated osis testcases to pass<br> _______________________________________________<br> sword-devel mailing list: <a href=3D"mailto:[email protected]" = target=3D"_blank">[email protected]</a><br> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" = target=3D"_blank">http://crosswire.org/mailman/listinfo/sword-devel</a><br= > Instructions to unsubscribe/change your settings at above page</p> = </blockquote></div>_______________________________________________<br>swor= d-devel mailing list: <a href=3D"mailto:[email protected]" = target=3D"_blank">[email protected]</a><br><a = href=3D"http://crosswire.org/mailman/listinfo/sword-devel" = target=3D"_blank">http://crosswire.org/mailman/listinfo/sword-devel</a><br= >Instructions to unsubscribe/change your settings at above = page<br></div></blockquote></div><br></div></div>_________________________= ______________________<br> sword-devel mailing list: <a href=3D"mailto:[email protected]" = target=3D"_blank">[email protected]</a><br> <a href=3D"http://crosswire.org/mailman/listinfo/sword-devel" = rel=3D"noreferrer" = target=3D"_blank">http://crosswire.org/mailman/listinfo/sword-devel</a><br= > Instructions to unsubscribe/change your settings at above page<br> </blockquote></div> _______________________________________________<br>sword-devel mailing = list: = [email protected]<br>http://crosswire.org/mailman/listinfo/sword-d= evel<br>Instructions to unsubscribe/change your settings at above = page<br></div></blockquote></div><br></body></html>= --Apple-Mail=_933F3EF8-7724-4BDB-A049-FB9DC859D1DD-- --===============4160035183394064634== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ sword-devel mailing list: [email protected] http://crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page --===============4160035183394064634==--