Re: Patch: handle denied updates correctly when using bind's view feature

[ resent - this didn't show up in the archives ]
Åge Strand wrote:
> Hi,
> 
> See the attached file "named.patch".
> 
> The attached "named-with-view-info.patch" file is an alternative way to
> fix this and provide extra information, i.e. the view name. Se comments
> below.
> 
> Bind has a feature called "views" which enables it to present a
> different view of a particular zone depending on the query client
> address scope.
> 
> As a consequence of using this feature, bind logs extra information when
> updates are denied. The current named script regexp is not capable of
> coping with the extra information, so all of these entries are logged as
> "Unmatched Entries". The patch addresses this problem.
> 
> Example, without the bind view feature:
> 02-Jul-2007 07:21:41.220 client 10.1.1.1#555: update 'example.com/IN'
> denied
> 
> Example, with the bind view feature:
> 02-Jul-2007 07:21:41.220 client 10.1.1.1#555: view someviewname: update
> 'example.com/IN' denied
> 
> Note: The "named.patch" patch does not catch and log the name of the
> view because I cannot be sure if changing the output will break
> applications depending on logwatch output. I have therefore included an
> alternative patch that does this, see the attached file
> "named-with-view-info.patch". If you think it is safe to change the
> output format you are free to use my patch.
> 
> Example of new format produced by "named-with-view-info.patch" :
> 
> Log entry with view feature enabled:
> 02-Jul-2007 07:21:41.220 client 10.1.1.1#555: view someviewname: update
> 'example.com/IN' denied
> 
> Yields the following output (the view name is now listed at the end):
> 10.1.1.1 (example.com/IN) view someviewname: 11 Time(s)
> 
> Log entry without view feature enabled:
> 02-Jul-2007 07:21:41.220 client 10.1.1.1#555: update 'example.com/IN'
> denied
> 
> Yields the following output (returns the old format without view info):
> 10.1.1.1 (example.com/IN): 11 Time(s)
> 
> 
> 
> Best regards,
> Åge Strand

Hi Åge,

Thanks for the update.  Views are partially supported by the named
script.  Why don't we use the same format as used for existing entries
such as:

Loaded Zones:
    0.0.127.in-addr.arpa/IN/internal: 6 Time(s)

where the viewname is added to the end of the Internet keyword IN.  So
you example will look like:

Zone update refused:
    10.1.1.1 (example.com/IN/someviewname): 11 Time(s)

As an aside, I have a number of unmatched entries that I can update as well.

MrC


_______________________________________________
Logwatch-Devel mailing list
[email protected]
http://www2.list.logwatch.org:81/mailman/listinfo/logwatch-devel