Re: qconfirm 0.14.3 compile error

On Sat, Jun 11, 2005 at 09:56:28PM -0400, Asif Iqbal wrote:
> On Tue, May 31, 2005 at 11:22:35PM, Asif Iqbal wrote:
> > On Tue, May 31, 2005 at 08:03:44PM, Gerrit Pape wrote:
> > > On Sun, May 29, 2005 at 06:48:45PM -0400, Asif Iqbal wrote:
> > > > While I am trying to compile qconfirm on my qmail (+daemontools) server
> > > > I get the following error message
> > > > 
> > > > Error:
> > > > Checking qconfirm-cdb-update...
> > > > $Id: qconfirm-cdb-update.c,v 1.7 2003/11/21 13:45:53 pape Exp $
> > > > usage: qconfirm-cdb-update [-vrf] [-c cdb] [-t sec] [-m min] [-l
> > > > 1..1000] [-s state]
> > > [...]
> > > The selftest of qconfirm-cdb-update failed for some reason.  You can
> > > re-run the selftest with package/check, does it fail reproducibly?
> > Here is output of the re-run. I am running it on Solaris 8 and gcc 3.2.1
> > [...]
> > qconfirm-cdb-update: fatal: unable to lock: ok.cdb: file descriptor not open
> > 100
> > example:org=-greg:
> > smarden:org=-floyd:
> > qconfirm-cdb-update: fatal: unable to lock: ok.cdb: file descriptor not open
> > [...]
> > qconfirm-cdb-update failed.
> > make: *** [check] Error 1
> 
> I am still having trouble compiling qconfirm on Solaris 8

I'm sorry, I don't know why acquiring the lock fails on your system;
AFAIK this problem hasn't been reported before, although there should
be qconfirm installations on solaris out there.

The error message is strange, the file descriptor definitely should be
open according to the source.  You could try the attached patch, and
please show compile/conf-* and compile/sysdeps, maybe another solaris
user has an idea.

Regards, Gerrit.

Index: src/qconfirm-cdb-update.c
===================================================================
RCS file: /var/lib/cvs/qconfirm/src/qconfirm-cdb-update.c,v
retrieving revision 1.7
diff -u -r1.7 qconfirm-cdb-update.c
--- src/qconfirm-cdb-update.c	21 Nov 2003 13:45:53 -0000	1.7
+++ src/qconfirm-cdb-update.c	14 Jun 2005 10:58:51 -0000
@@ -192,9 +192,10 @@
   if (cdb_make_start(&c, fdtmp) == -1) fatal("unable to create: ", tmp.s);
   if (fdcdb != -1) {
     /* lock data.cdb */
-    if (lock_exnb(fdcdb) == -1)
+    if (lock_exnb(fdcdb) == -1) {
       if (verbose) warn("lock is busy, waiting...: ", cdbfn);
-    if (lock_ex(fdcdb) == -1) fatal("unable to lock: ", cdbfn);
+      if (lock_ex(fdcdb) == -1) fatal("unable to lock: ", cdbfn);
+    }
     buffer_init(&bcdb, buffer_unixread, fdcdb, bcdbspace, sizeof bcdbspace);
     /* size of database */
     get(&bcdb, uintbuf, 4);