RE: I minor error found in gw/smsc_at2.c

"Oded Arbel" <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Message-ID <[email protected]>
> -----Original Message-----
> From: Stipe Tolj [mailto:[email protected]]
> "Nektarios K. Papadopoulos" wrote:
> > I think that passing octstr_case_compare to list_search, makes it to
> > search for at least one non matching list element, insteat for one
> > matching.
> > So I suggest changing it to octstr_item_match, since we 
> care only for
> > digits.
> > 
> > the diff with todays cvs is attached, in case I am not wrong.
> 
> any votes from the others, please?!
> 
> Putting this at least to STATUS for now.

I agree. its an honest mistake - octstr_case_compare returns 0 for a
match, while list_search expects 1 for a match. using item_match will be
correct.

Oded Arbel
m-Wise Inc.
[email protected]

--
Maintainer's Motto:
If we can't fix it, it ain't broke.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.