Re: Major bug ? (Was: Fw: Daily patch: gateway)

Hi Bruno

Bruno David Rodrigues wrote:

> Have you checked your patch ? like killing smsbox and checking the zillion
> warnings ?

in general yes, I do test things before commiting.

> Every line in kannel.conf would create a new octstr in that
> octstr_duplicate!

that's right, we hold the required structure of *every* line
containing the filename where it was defined and at which line.

> I've checked the code and the functioning of this module is something like
> this:
> 
> . kannel reads the file and search for empty lines (*1).
> . It reads the <name> = <value> and add it to a hash table (grp)
> . when it gets to another empty line, add that group to another hash table
> (cfg) and create a
> new group (grp).

yep.

> Then later, it will check for a group = <something> for each grp in cfg.
> 
> The hash table function (dict_put) only accepts a key and a value, so you
> can't put the line
> number in it, therefor you can't inject the line number for every line read.

that's not what was my intension, I only wanted to have a more
semantical error message, informing the user where things break at
startup time.

> The best we can do is to define the filename and first line of the group.
> 
> I'm commiting a patch for this one.

I'd like to see that.

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are