CMTI patch - revisited...

Rene Kluwen / Chimit Software Solutions <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Message-ID <[email protected]>
Hello devel,

  Please find attached a CMTI-patch.
  It does not call at2_wait_modem_command recursively.

  The changes are relatively big, compared to my first quick hack (but
  hey, you asked for it ;]).

  I made a seperate queue in the privdata struct and I put CMTI
  notifications in it.
  The queue is emptied again in the main thread.
  The code that reads and deletes a message from memory is put in a
  seperate function (first it was part of the sim-buffering code).

  I read the CodingStyle doc and tried to follow the advice that I got
  in this list. But let me know if you want things to be done
  differently. I am still getting into this project.

  One question though: In the function smscenter_receive_msg() in
  sms.c, all the different kinds of smsc-interfaces are queried for
  pending messages. Only the at2 smsc is not there. Why? Is this
  function depricated and replaced by the bb_smsccon functions?

  Any comments are welcome.


-- 
Best regards,
 Rene                          mailto:[email protected]
cmti_patch.udiff (application/octet-stream, 8.9 KB) - not displayed
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.