[PATCH] Chararcter @ in SMPP
"Dedy Sutanto" <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <C5554AEAB8B4DA44A98764E3214B8416B844EF@Jktgrhxmx01.intra.excelcom.co.id> |
Dear all I'd like to propose patch to fix problem with character @ in SMPP. Since, I read from kannel userguide.html, the character @ in SMPP has sign "y?". It means "driver probably has this feature, has not been tested". Then I tested it. The conclusion is the problem seems still there because kannel mapping "@" to "I". This patch will patch file charset.c (below dir /gwlib). I notice that smsc_smpp.c use character set defined in charset.c file. I modified character mapping (for @) in charset.c. I already use this patch since 1.2.0 in CVS (maybe since 1.1.6 - don't remember) and it work for me. I used it for my sms to mail and mail to sms services. Please take a look on this patch, because I only test it in SMPP environment. I am afraid this patch affects other driver. Kindly Regards -dedy-
charset.patch
(application/octet-stream, 1.2 KB)
--- charset.c.org Wed Oct 2 10:50:06 2002
+++ charset.c.modif Wed Oct 2 10:47:31 2002
@@ -23,7 +23,10 @@
'(', ')', '*', '+', ',', '-', '.', '/', /* 40 - 47 */
'0', '1', '2', '3', '4', '5', '6', '7', /* 48 - 55 */
'8', '9', ':', ';', '<', '=', '>', '?', /* 56 - 63 */
- 0xa1, 'A', 'B', 'C', 'D', 'E', 'F', 'G', /* 64 - 71 */
+/*
+ 0xa1, 'A', 'B', 'C', 'D', 'E', 'F', 'G', */ /* 64 - 71 */
+
+ '@', 'A', 'B', 'C', 'D', 'E', 'F', 'G', /* 64 - 71 */
'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', /* 73 - 79 */
'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', /* 80 - 87 */
'X', 'Y', 'Z', 0xc4, 0xd6, 0xd1, 0xdc, 0xa7, /* 88 - 95 */
@@ -78,7 +81,10 @@
'0', '1', '2', '3', '4', '5', '6', '7', /* 48 - 55 */
'8', '9', ':', ';', '<', '=', '>', '?', /* 56 - 63 */
/* @ maps to 0 */
- 0, 'A', 'B', 'C', 'D', 'E', 'F', 'G', /* 64 - 71 */
+/*
+ 0, 'A', 'B', 'C', 'D', 'E', 'F', 'G', */ /* 64 - 71 */
+
+ '@', 'A', 'B', 'C', 'D', 'E', 'F', 'G', /* 64 - 71 */
'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', /* 72 - 79 */
'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', /* 80 - 87 */
/* [ is an escaped < */