RE: [PATCH] Chararcter @ in SMPP
"Oded Arbel" <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
I'm sorry, but I have to vote -1 on this patch. I would have voted -2 if possible, because this patch breaks standard compatibility in Kannel entirly (GSM 03.38) in order to support a small number of broken SMSC. there is a problem with @ mapping in some non-standard compliant SMSCs, but I don't think that the solution is to break Kannel to match - mostly as that would make Kannel non-standard compliant, and secondly as that would cause it not to work with other SMSCs that _are_ standard compliant. I would suggest that we either implement a 'quirks' setting as I suggested in the 'SMPP data coding' thread to also handle that, or use the already existing alt-charset setting to catch that for broken SMPP server implementations -- Oded Arbel m-Wise mobile solutions [email protected] +972-9-9581711 (116) +972-67-340014 ::.. As long as there are ill-defined goals, bizarre bugs, and unrealistic schedules, there will be Real Programmers willing to jump in and Solve The Problem, saving the documentation for later. -----Original Message----- From: Dedy Sutanto [mailto:[email protected]] Sent: Wednesday, October 02, 2002 6:43 AM To: [email protected] Subject: [PATCH] Chararcter @ in SMPP Dear all I'd like to propose patch to fix problem with character @ in SMPP. Since, I read from kannel userguide.html, the character @ in SMPP has sign "y?". It means "driver probably has this feature, has not been tested". Then I tested it. The conclusion is the problem seems still there because kannel mapping "@" to "I". This patch will patch file charset.c (below dir /gwlib). I notice that smsc_smpp.c use character set defined in charset.c file. I modified character mapping (for @) in charset.c. I already use this patch since 1.2.0 in CVS (maybe since 1.1.6 - don't remember) and it work for me. I used it for my sms to mail and mail to sms services. Please take a look on this patch, because I only test it in SMPP environment. I am afraid this patch affects other driver. Kindly Regards -dedy-