Bug in smsc_smpp.c

"Paul Keogh" <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Message-ID <[email protected]>
The handling of errors returned by the read_pdu() is inadequate.

When read_pdu() fails due to a conn error, the io_thread() function
goes into a hard CPU loop and never exits.

read_pdu() can fail for a malformed SMPP PDU or a conn error.
The same return code is returned for both conditions.

I propose to add a separate return code for conn failures (-2)
so that the calling function can attempt to reopen the connections
subject to reopen delays and number of retry attempts etc.

So view this as a bug report and a proposed solution. I'll post
a patch once I've validated it.

Paul Keogh
ANAM Wireless Internet Solutions
http://www.anam.com                     
+353 1 284 7555 (wired)               +353 86 234 6047 (wireless)
Castle Yard, Saint Patrick's Road, Dalkey, County Dublin, Ireland
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.