Re: Bug in smsc_smpp.c
Stipe Tolj <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | Wapme Systems AG |
| Message-ID | <[email protected]> |
Paul Keogh wrote: > > The handling of errors returned by the read_pdu() is inadequate. > > When read_pdu() fails due to a conn error, the io_thread() function > goes into a hard CPU loop and never exits. > > read_pdu() can fail for a malformed SMPP PDU or a conn error. > The same return code is returned for both conditions. > > I propose to add a separate return code for conn failures (-2) > so that the calling function can attempt to reopen the connections > subject to reopen delays and number of retry attempts etc. > > So view this as a bug report and a proposed solution. I'll post > a patch once I've validated it. waiting for that. Is it coming in the near future?! Should be done very simple I guess. Stipe [email protected] ------------------------------------------------------------------- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [email protected] Internet: http://www.wapme-systems.de ------------------------------------------------------------------- wapme.net - wherever you are