RE: repost: [PATCH] SMPP: data_coding (deliver_sm) votes?!

Hi Oded,

It was included - but as mentioned implied iconv was required not
optional. It sounds like the preference would be to have as optional
(propagate the code with a few ifdef's, etc) and default to
gsm_to_latin1 conversion regardless of encoding (will look at this
shortly).

Given that even libxml requires iconv for full support - it would be
nice to at least 'recommend' iconv when compiling kannel esp considering
things may not work as they should in smpp world for some.   

On Fri, 2002-11-22 at 03:23, Oded Arbel wrote:
> The original charset_convert patch had a patch for configure. it should have been in the current patch - I'll look into it again.
> 
> --
> Oded Arbel
> m-Wise mobile solutions
> [email protected]
> 
> +972-9-9581711 (116)
> +972-67-340014
> 
> ::..
> There is no spoon. (only annoying little kids) !
> 
> 
> 
> 
> > -----Original Message-----
> > From: Stipe Tolj [mailto:[email protected]]
> > Sent: Thursday, November 21, 2002 2:10 AM
> > To: Oded Arbel
> > Cc: Andreas Fink; [email protected]
> > Subject: Re: repost: [PATCH] SMPP: data_coding (deliver_sm) votes?!
> > 
> > 
> > the patch tests on the header files, not on the library itself. BTW,
> > the patch does not work when linking the executables for me, because
> > configure has not added any lib dependecy statements for ld.
> > 
> > Ok, I'd propose the following behaviour:
> > 
> > configure tests on iconv presence. If available sets #define
> > HAVE_ICONV in config.h and the iconv routines are used directly in the
> > code. If not available use the "old" behaviour.
> > 
> > What about that approach?
> > 
> > Stipe
> > 
> > [email protected]
> > -------------------------------------------------------------------
> > Wapme Systems AG
> > 
> > Vogelsanger Weg 80
> > 40470 Düsseldorf
> > 
> > Tel: +49-211-74845-0
> > Fax: +49-211-74845-299
> > 
> > E-Mail: [email protected]
> > Internet: http://www.wapme-systems.de
> > -------------------------------------------------------------------
> > wapme.net - wherever you are
> > 
> 
> 
-- 
Alan McNatty -- Catalyst IT Ltd -- http://www.catalyst.net.nz
  Level 2, 150-154 Willis St, PO Box 11-053, Wellington, NZ
Mob: +64 272555332, DDI: +64 4 9167203, Office: +64 4 4992267