RE: repost: [PATCH] SMPP: data_coding (deliver_sm) votes?!
Oded Arbel <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | m-Wise mobile solutions |
| Message-ID | <[email protected]> |
On Fri, 2002-11-22 at 04:54, Alan McNatty wrote: > Hi Oded, > > It was included - but as mentioned implied iconv was required not > optional. No so - configure will check for it and set HAVE_ICONV only if the header file exists (which to me suggests that the library is installed - I don't know many people who hold on their build systems headers for libraries they don't have installed. > It sounds like the preference would be to have as optional > (propagate the code with a few ifdef's, etc) and default to > gsm_to_latin1 conversion regardless of encoding (will look at this > shortly). Don't think that's a correct approach. coding anything to latin1 regardless of the SMSC's preferences or the user's preferences just because they user did not specificly enable a feature which should be auto-detected does not sound like a good idea to me. -- Oded Arbel m-Wise mobile solutions ______________________________________________________ Scanned and protected by Inflex and McAfee AntiVirus