Re: repost: [PATCH] SMPP: data_coding (deliver_sm) votes?!

On Sun, 2002-11-24 at 05:34, Stipe Tolj wrote:

> > I would leave it in gsm character set as far as possible because the receiver might want to do its own conversion. And converting it to latin1 is not lossless.
> > 
> > in any case not convert it if coding means its binary
> 
> yep, agreed, binary things should never be converted.

Ahmm.. may I point to the fact that the patch Alan submitted already
does these two last discussed issues:
- convert using iconv when possible
- warn when failing
- allows setting "binary" to prevent encoding of "default data coding"

The only thing it does not do is to warn if encoding is needed and iconv
is not available. this could be easily fixed by adding an #else section
to the charset_convert body's #ifdef, that try to do conversion using
libxml and outputs an error if it fails. if no one will beat me to it, I
can have a patch that does it in a couple of days.

--
Oded Arbel
m-Wise mobile solutions

______________________________________________________
 Scanned and protected by Inflex and McAfee AntiVirus