Re: repost: [PATCH] SMPP: data_coding (deliver_sm) votes?!

On Sonntag, November 24, 2002, at 04:35  Uhr, Alan McNatty wrote:

> On Fri, 2002-11-22 at 21:04, Andreas Fink wrote:
>> Why gsm_to_latin1 if we know encoding?
>
> We don't, well the smpp driver doesn't - that's the whole point of this
> patch. In the case where the data coding is set to SMSC default (0x00) 
> -
> the smpp driver doesn't know what decoding to do.


Well the spec says that its GSM character set.

>  We need to be able to
> specify via the config what encoding each smsc coonsiders to be it's
> default - they do vary.

Ok. that would be a config variable telling which one to be considered.

> Currently all incomming are assumed to gsm hence gsm_to_latin1 encoding
> is performed on all incomming messages from all smsc via smpp driver.
> However, the SMSC default encoding could easily be ASCII, for example.
>

yes but what I'm saying that is we should leave it in the character set 
it is.
gsm_to_latin1 is something which is not a good idea either as it is run 
also on binary and unicode content  in the current code. In a situation 
where you chain multiple kannels for incoming you simply want to 
forward the incoming SMS "as is" without modifiying it whatsoever. 
indicating what encodig default means is ok but we should not in any 
way modifiy the data at this point. We should maybe do it in smsbox 
where we forward it to a webpage and indicate there which character set 
the webpage accepts and then convert it once. We want to avoid 
situations where we do

gsm character set -> latin1 -> gsm character set

as some characters would not pass this way.


> -- consider --
>
> If iconv is not available or no default is set via config and the data
> coding is smsc default (0x00) - we assume gsm encoding so the default
> behaviour is the same as current.
>
> Alternatively, if iconv is not available and data coding requires iconv
> or data coding is set via config to something which would require 
> iconv,
> we sould error and do no conversion (because we can't).
>
> Otherwise - we utilise Oded's work with iconv to do sensible decoding 
> of
> incomming message.
>

the idea is good but the SMPP driver is the wrong place do to this.
the only thing we should do there is to say what is considered the 
default so we can convert it if needed when the message leaves kannel.

Andreas Fink
Global Networks, Inc.

------------------------------------------------------------------
Tel: +41-61-6666333  Fax: +41-61-6932729   Mobile: +41-79-2457333
Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland
Web: http://www.global-networks.ch/      [email protected]
------------------------------------------------------------------
Member of the GSM Association