Re: Bug - sent messages counted twice in SMSC AT2 driver.

Stipe Tolj <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Organization Wapme Systems AG
Message-ID <[email protected]>
Paul Keogh wrote:
> 
> In the function at2_send_one_message()/smsc_at2.c, the lines
> 
>             counter_increase(privdata->conn->sent);
>             bb_smscconn_sent(privdata->conn, msg);
> 
> increment the sent messages counter twice because bb_smscconn_sent()
> also does;
> 
>     counter_increase(outgoing_sms_counter);
>     if (conn) counter_increase(conn->sent);
> 
> Thus, conn->sent is incremented twice. The counter_increase() in the
> AT2 driver should be removed.

yep, +1, commited.

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.