Re: [PATCH] Http-timeout

I think that threaded version realy more clean and maintainable.
As I wrote in previouse posts perfomance of non-threaded version
depends on load, but for threaded version perfomance is constant.

I am +1 for 1).

Nisan Bloch wrote:
> Hi
> 
> I agree with Alexander here - if the threaded version shows no real 
> gains, then why include it - more source to maintain - more chance of 
> bugs etc. The non-thread ver is enough of a gain as is.
> 
> +1 for 2
> 
> Nisan
> At 12:31 PM 2003/12/02, Alexander  Malysh wrote:
> 
>> Hi,
>>
>> On Tuesday 02 December 2003 11:10, Stipe Tolj wrote:
>> > David Schmitz wrote:
>> > > attached are two patches for the HTTP-timeout thing. The first one 
>> uses
>> > > a threaded-approach and the second one works without threads. As some
>> > > tests have shown, the threaded version only performs better in 
>> high-load
>> > > situations, and even then only marginally. Thus, I would like you to
>> > > test vote on one of four possibilities:
>> > > 1. commit thread-solution
>> > > 2. commit non-thread-solution
>> > > 3. merge both and make it selectable with a precompiler-directive
>> > > 4. delete the whole thing.
>> >
>> > if we'd pick optionm 3, how long would it take?
>>
>> Stipe, are you really want more complicated http-module as needed?
>> I would propose to stress-test/benchmark 2 patches and vote for only 
>> one for
>> inclusion...
>>
>> P.S. I'm +1 for 4) ;) (just a joke)
>>
>> >
>> > Stipe
>> >
>> > mailto:[email protected]
>> > -------------------------------------------------------------------
>> > Wapme Systems AG
>> >
>> > Münsterstr. 248
>> > 40470 Düsseldorf, NRW, Germany
>> >
>> > phone: +49.211.74845.0
>> > fax: +49.211.74845.299
>> >
>> > mailto:[email protected]
>> > http://www.wapme-systems.de/
>> > -------------------------------------------------------------------
>> >
>> > -----BEGIN PGP PUBLIC KEY BLOCK-----
>> > Version: GnuPG v1.2.2 (Cygwin)
>> >
>> > mIsEP6mcYwEEAMDnUiUwrbb+xwTFWN6TxF2+XZu7/alwJMeCwMBRvXtPZqfjpPhS
>> > OkBpU0F4TrVuugz1HINTSaJTYq10AzDQXp5NkyWgckqW79nPAWuOX0dicbJk+cN2
>> > nM2TI4KaxUDe6u8hghNEnH/i2lXsUu9apnP/iixzV81VC2je3uc9hZpnAAYptEVT
>> > dGlwZSBUb2xqIChUZWNobm9sb2d5IENlbnRlciAmIFJlc2VhcmNoIExhYikgPHRv
>> > bGpAd2FwbWUtc3lzdGVtcy5kZT6ItAQTAQIAHgUCP6mcYwIbAwYLCQgHAwIDFQID
>> > AxYCAQIeAQIXgAAKCRABV0w1BqPYRuSqA/wPzsQxao2YePENCtgRTrO86U6zg3sl
>> > OcS6CJFI4FZP5h/xD3GRsNH1+MPSvZlomDdpFnr547DGz/Kq9MXuQwVvlVig5yWZ
>> > K5dtKp1r5YLhxJQBhfirZbRFFnYmf19f18J8OoS28tuFVftDl1AIwJS3HLyBTv6H
>> > g2HyLAEKQIp30Q==
>> > =aYCI
>> > -----END PGP PUBLIC KEY BLOCK-----
>>
>> -- 
>> Best regards / Mit besten Grüßen aus Düsseldorf
>>
>> Dipl.-Ing.
>> Alexander Malysh
>> ___________________________________________
>>
>> Centrium GmbH
>> Vogelsanger Weg 80
>> 40470 Düsseldorf
>>
>> Fon: +49 (0211) 74 84 51 80
>> Fax: +49 (0211) 277 49 109
>>
>> email: [email protected]
>> web: www.centrium.de
>> msn: [email protected]
>> icq: 98063111
>> ___________________________________________
>>
>> Please avoid sending me Word, Excel or PowerPoint attachments.
>> See http://www.fsf.org/philosophy/no-word-attachments.html
> 
> 
> 


-- 
Vjacheslav Chekushin                                mailto:[email protected]
Latvian Mobile Phone Company                        http://www.lmt.lv
Network Support and Information Technology Group    +371 7773436
                                                     +371 9248284 (mobile)