Re: smsc_at.c fix

Hi Alex,

good catch , but it's not enough... smsc_at doesn't propperly reconnect device 
(device should be closed and reopened, because some modems get confused) 
etc...

Please be patient, I will merge Centrium's changes for smsc-at...

On Tuesday 16 December 2003 18:04, Alex Judd wrote:
> For those using the AT driver recently you might have noticed it's been
> very unreliable at opening serial ports properly. This is because part of
> the init code was using the old open_device1 rather than the superior
> open_device function.
>
> If you replace them to use the open_device, serial device opening is
> significantly better - and here's the quick patch
>
> Regards
>
> Alex
>
> --- smsc_at.c   Tue Dec 16 17:33:01 2003
> +++ smsc_at.c.alex      Tue Dec 16 17:31:44 2003
> @@ -2104,7 +2104,7 @@
>
>      int res;
>
> -    if (at2_open_device1(privdata) == -1)
> +    if (at2_open_device(privdata) == -1)
>         return -1;
>
>      at2_set_speed(privdata, speed);
> @@ -2130,7 +2130,7 @@
>
>      debug("bb.smsc.at2", 0, "AT2[%s]: detecting modem type",
> octstr_get_cstr(privdata->name));
>
> -    if (at2_open_device1(privdata) == -1)
> +    if (at2_open_device(privdata) == -1)
>          return -1;
>
>      at2_set_speed(privdata, privdata->speed);

-- 
Best regards / Mit besten Grüßen aus Düsseldorf

Dipl.-Ing.
Alexander Malysh
___________________________________________

Centrium GmbH
Vogelsanger Weg 80
40470 Düsseldorf

Fon: +49 (0211) 74 84 51 80
Fax: +49 (0211) 277 49 109

email: [email protected]
web: www.centrium.de
msn: [email protected]
icq: 98063111
___________________________________________

Please avoid sending me Word, Excel or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html