Re: Miscellaneous diffs

Stipe Tolj <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Organization Wapme Systems AG
Message-ID <[email protected]>
> 1. date.c - The function for making iso dates seems to have not been
> outputing these right, hence causing errors in some applications that
> depends on this.

+1.

> 2. mime.[ch] - several changes:
>         -  Making the mime boundary string a bit more 'safe': Added random
> numbers and chars to it.

yep, this add's computation time, but it is definetly secondary to
parsing safety.
We could do here a UUID creation and then drop it in as boundary
delimiter? Comments on this?

>         - When converting Octstr * to MIMEEntity *, a safer way to detect if
> each mime entity ends with \r\n or just \n

ok, to me.

>         - Corrected mis-spelling in comment.
> 3. wsp_headers.[ch] - Various changes
>                 - Exposed a few more functions (i.e. changed from static) as they are
> useful in other applications. Added wsp_ prefix to these.

yep, same as I did for various.

>                 - Detection of WSP_QUOTE and '"' as well in wsp_field_value(). At
> least one application barfed on this as it produced quote literal
>                 - wsp_strip_parameters was not dealing correctly with " enclosed
> values. Kept getting stray " at the beginning.

ok, to me.


@Aarno: +1 from me. If you don't have the time, drop me a note, I'll
commit.

Stipe

mailto:[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf, NRW, Germany

phone: +49.211.74845.0
fax: +49.211.74845.299

mailto:[email protected]
http://www.wapme-systems.de/
-------------------------------------------------------------------

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1.2.2 (Cygwin)

mIsEP6mcYwEEAMDnUiUwrbb+xwTFWN6TxF2+XZu7/alwJMeCwMBRvXtPZqfjpPhS
OkBpU0F4TrVuugz1HINTSaJTYq10AzDQXp5NkyWgckqW79nPAWuOX0dicbJk+cN2
nM2TI4KaxUDe6u8hghNEnH/i2lXsUu9apnP/iixzV81VC2je3uc9hZpnAAYptEVT
dGlwZSBUb2xqIChUZWNobm9sb2d5IENlbnRlciAmIFJlc2VhcmNoIExhYikgPHRv
bGpAd2FwbWUtc3lzdGVtcy5kZT6ItAQTAQIAHgUCP6mcYwIbAwYLCQgHAwIDFQID
AxYCAQIeAQIXgAAKCRABV0w1BqPYRuSqA/wPzsQxao2YePENCtgRTrO86U6zg3sl
OcS6CJFI4FZP5h/xD3GRsNH1+MPSvZlomDdpFnr547DGz/Kq9MXuQwVvlVig5yWZ
K5dtKp1r5YLhxJQBhfirZbRFFnYmf19f18J8OoS28tuFVftDl1AIwJS3HLyBTv6H
g2HyLAEKQIp30Q==
=aYCI
-----END PGP PUBLIC KEY BLOCK-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.