Re: [PATCH] curl

Paul P Komkoff Jr <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Organization Department of Fish & Wildlife
Message-ID <[email protected]>
Replying to Stipe Tolj:
> As far as I understand, this means, libcurl support is optional via 
> configure switch --enable-curl, right?

Yes, that is for those people who want gwlib's http for some reason.
My testing shows that curl is more reliable, though ... ;(

> Some points I'd like to see cleaned:
> 
> * moving curl_XXX functions to an "own" file instead of mudging it into 
> gw/wap-appl.c. This is not the appropriate place IMO.

I will do this in 1-2 days, retest and resubmit it.

> * code style. See doc/CodingStyle for our "coding rules" ;)

uh oh ... the mess with idents out there was basically from
mouse-copying between incapable terminals and shifts between different
version control systems ...

> Paul, if you could revise these point and re-submit a new patch, I'd be 
> willing to test directly and vote +1 for commiting. Mainly since this would 
> imply that libcurl support is OPTIONAL.

After dsmagic people apper with these mbuni mms toolkit, I noticed
that they use http client gwlib also in their code. I think they can
benefit from using curl too. So, I will extract all specific code into
specific files.

> User's are legitim individuals to pick on their own, what they want.

Ehh... by the way, will autoconf conversion on which I and amalysh spent
not less than 12 intensive development hours, will it be ever
integrated?

-- 
Paul P 'Stingray' Komkoff Jr // http://stingr.net/key <- my pgp key
 This message represents the official view of the voices in my head
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.