Re: [PATCH] charset
Paul P Komkoff Jr <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | Department of Fish & Wildlife |
| Message-ID | <[email protected]> |
Replying to Alexander Malysh: > why NEW_CHARSET? would it be possible to name this as help message (e.g. > UTF8_CHARSET) because it's just confusing at least me? ok I will > + charset = octstr_duplicate(content.charset); > ^^^^ possible memleak why ? octstr_create_from_data_trace(ostr->data, ostr->len, file, line, func); no differs than octstr_create_from_data_trace(cstr, strlen(cstr), file, line, func); except in cases where content.charset contains inner zeros. > Please either octstr_imm(...) or octstr_create(...).. And there are octstr_destroy(charset) at the end of that block. And content.charset can be changed later ... -- Paul P 'Stingray' Komkoff Jr // http://stingr.net/key <- my pgp key This message represents the official view of the voices in my head