Re: Needed Repair

hi,

fixed in cvs...
Thanks for report!


Jonathan Houser wrote:

> 
> Kannel Devel,
> 
>       Someone over there needs to add the line:
> 
> msisdn = radius_acct_get_msisdn(addr_tuple->remote->address);
> 
>       back into gw/wap-appl.c ASAP.  This line got removed somehow via
> the "print the IP/port of the WAP client" patch.  This is why compiler
> warnings are popping up regarding that.  The "check to be sure the IP
> isn't NULL" patch isn't needed.  The problem is that 'msisdn' is being
> passed uninitialized to the following lines:
> 
> info(0, "Fetching URL <%s> for MSISDN <%s>, IP <%s:%d>",
> octstr_get_cstr(url),
> ...
> 
>       The final code block should look like:
> 
> msisdn = radius_acct_get_msisdn(addr_tuple->remote->address);
> info(0, "Fetching URL <%s> for MSISDN <%s>, IP <%s:%d>",
> octstr_get_cstr(url), msisdn ? octstr_get_cstr(msisdn) : "",
> octstr_get_cstr(addr_tuple->remote->address), addr_tuple->remote->port);
> 
>       Until this is fixed, anyone using wapbox with basic logging will
> PANIC (and die) as soon as they get a request.
> 
> Jon

-- 
Thanks,
Alex