Re: Needed Repair

Jonathan Houser wrote:

> 
>       Kannel Devel,
> 
>      Someone over there needs to add the line:
> 
> msisdn = radius_acct_get_msisdn(addr_tuple->remote->address);
> 
>      back into gw/wap-appl.c ASAP.  This line got removed somehow via 
> the "print the IP/port of the WAP client" patch.  This is why compiler 
> warnings are popping up regarding that.  The "check to be sure the IP 
> isn't NULL" patch isn't needed.  The problem is that 'msisdn' is being 
> passed uninitialized to the following lines:
> 
> info(0, "Fetching URL <%s> for MSISDN <%s>, IP <%s:%d>", 
> octstr_get_cstr(url),
> ...
> 
>      The final code block should look like:
> 
> msisdn = radius_acct_get_msisdn(addr_tuple->remote->address);
> info(0, "Fetching URL <%s> for MSISDN <%s>, IP <%s:%d>", 
> octstr_get_cstr(url), msisdn ? octstr_get_cstr(msisdn) : "", 
> octstr_get_cstr(addr_tuple->remote->address), addr_tuple->remote->port);
> 
>      Until this is fixed, anyone using wapbox with basic logging will 
> PANIC (and die) as soon as they get a request.

ups, my fault... all shame on me.

I deleted the line while commiting your patch to add the IP output to the info() 
line, see

http://www.kannel.org/cgi-bin/viewcvs.cgi/gateway/gw/wap-appl.c.diff?r1=1.109&r2=1.110

@Alex: thanks for jumping in and fixing. Sorry.

Stipe

mailto:stolj_{at}_wapme.de
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf, NRW, Germany

phone: +49.211.74845.0
fax: +49.211.74845.299

mailto:info_{at}_wapme-systems.de
http://www.wapme-systems.de/
-------------------------------------------------------------------